fix(ci): restore signed commits using changesets API with husky file fix#102
Closed
pasevin wants to merge 2 commits into
Closed
fix(ci): restore signed commits using changesets API with husky file fix#102pasevin wants to merge 2 commits into
pasevin wants to merge 2 commits into
Conversation
collins-w
reviewed
Aug 13, 2025
| with: | ||
| commit: 'chore: update export versions' | ||
| title: 'chore: update export versions' | ||
| setupGitUser: true |
Contributor
There was a problem hiding this comment.
Nit: By default is true, so maybe we can remove the line.
Collaborator
Author
|
Closing this PR as the changes are minor and don't address the core signing issue. The real fix is in PR #103 which restores commitMode: 'github-api' for signed commits in the publish workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores signed commits in the update-versions workflow by using changesets action with GitHub API while fixing the executable files issue. The previous fix removed GitHub API usage, resulting in unsigned commits. This solution uses changesets action for signed commits while temporarily removing executable permissions from Husky files for API compatibility.