Notify now honors withpath parameter#432
Conversation
50b9505 to
230960a
Compare
Sharpie
left a comment
There was a problem hiding this comment.
Apologies for the delay in reviewing this PR. This looks like a good set of changes for OpenVox 9. @acesso could you re-base your pull request against the main branch?
That should kick the test suite. The commit in this PR will also need to be signed with a SSH or GPG key.
6a80118 to
037bb16
Compare
Notify should not represent a state of a resource since it only "exists" during execution time. This change proposes that it should be considered to always "exist", thus avoiding a change notification. Signed-off-by: acesso <[email protected]>
037bb16 to
c11f2ac
Compare
|
Looks like this caused quite a few failures in the testing suite. I applied the patch locally and compared Unfortunately, event creation is pretty intrinsic to how Alternately, the |
When running Puppet agent with the -t flag, notify resources currently log duplicate messages: one for the explicit message itself, and another for the resource state change (creation/sync). This creates unnecessary log noise, making it harder to spot actual infrastructure changes.
This change modifies the notify resource to always be considered as "existing." By preventing the resource from triggering an out-of-sync event, Puppet will no longer log the redundant state-change notification, resulting in cleaner and more readable execution logs.
The
withpathparameter now makes sense to be used, since the possible need to actually show the resource path.Checklist
I have:
Signed-off-byannotation to each of my commits