fix(logging): rename isEventEnabled to shouldLogEvent#274
Closed
Alexteens24 wants to merge 1 commit into
Closed
Conversation
…ntics Align LoggingConfig with DiscordWebhookConfig: the method now returns true when an event should be logged, preventing confusion from the inverted name. Co-authored-by: Cursor <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LoggingConfig.isEventEnabled()toshouldLogEvent()with intuitive semantics (enabled && enabledEvents.contains(eventType)), matchingDiscordWebhookConfig.SpawnerActionLoggerguards to use the new method.Replaces the closed #273 with a minimal, focused change.