feat: add createExternalStore utility and ClockProvider (v4 backport)#247
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Backport of #195 to v4.x. Adds a generic external store factory (createExternalStore) using useSyncExternalStore that lets components subscribe to frequently-updating data sources without unnecessary re-renders, plus a pre-built clock store (ClockProvider, useClock, useClockSelector) wrapping the existing Clock component. Tests use @testing-library/react@11 for React 16 compatibility.
gcutrini
force-pushed
the
feature/external-store-clock-context-v4
branch
from
49de34b to
148bd3c
Compare
…seSyncExternalStoreWithSelector Delegates selector + equality handling to the react-recommended primitive from use-sync-external-store. Removes the manual ref bookkeeping, the null-sentinel ambiguity for cached results, and the useCallback dependency on isEqual that recreated the snapshot closure on every parent render.
Provider now accepts initialValue so getSnapshot returns a real value before the first emit. ClockProvider forwards its now prop as initialValue so consumers reading useClock or useClockSelector during the initial render see a valid timestamp instead of null.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: https://app.clickup.com/t/86b8e70g2
Backport of #195 to the v4.x maintenance branch so event-site (currently on uicore 4.2.29) can adopt ClockProvider without committing to a full MUI v5 -> v6 migration up-front.
What's included
src/utils/external-store.js— genericcreateExternalStorefactory built onuseSyncExternalStoresrc/components/clock-context.js—ClockProvider,useClock,useClockSelector(wraps the existing Clock)components/clock-context,utils/external-storesrc/components/index.jsuse-sync-external-store@^1.6.0Tests
24 new tests (12 for the store factory, 8 for the clock context, 4 misc). Pinned
@testing-library/react@^11for React 16 compatibility (the v5 PR uses v12+). Full suite: 123/123 pass.Notes
reactone when the v5 line moves to React 18.