Comment and Test Coverage#7
Merged
Merged
Conversation
1. Stale comment removed. The old NOTE block said validation.md had wrong GH card strings. Steve fixed the document itself, but the comment is wrong. This commit should fix this. It has been replaced with a brief description of the new parse tests. 2. Two parse-level tests added. `v_hel_001_parse_card_string` and `v_hel_002_parse_card_string`. They feed the literal card strings from `validation.md` through `arcanum_nec_import::parse()` then into `build_mesh()` and assert the same geometry values the struct-based tests already verify. If anyone ever edits the card string in the doc and breaks the field order, these tests will catch it immediately instead of silently.
Abraxas3d
added
documentation
Formatter failure from the automated checker. I copied how Steve does his files and hopefully this will do the trick.
sconklin
approved these changes
May 21, 2026
Contributor
sconklin
left a comment
sconklin
left a comment
There was a problem hiding this comment.
Looks good! Thanks for the fix, and for catching the test failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v_hel_001_parse_card_stringandv_hel_002_parse_card_string. They feed the literal card strings fromvalidation.mdthrougharcanum_nec_import::parse()then intobuild_mesh()and assert the same geometry values the struct-based tests already verify. If anyone ever edits the card string in the doc and breaks the field order, these tests will catch it immediately instead of silently.