Security: Unsafe Pickle Usage in FileLogger#690
Open
tuanaiseo wants to merge 1 commit into
Open
Conversation
The FileLogger class in src/art/langgraph/logging.py uses pickle.dump and pickle.load to serialize and deserialize log entries. Pickle is unsafe for untrusted data as it can execute arbitrary code during deserialization. An attacker with write access to the pickle file or the ability to control log entries could achieve remote code execution. Affected files: logging.py Signed-off-by: tuanaiseo <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The FileLogger class in src/art/langgraph/logging.py uses pickle.dump and pickle.load to serialize and deserialize log entries. Pickle is unsafe for untrusted data as it can execute arbitrary code during deserialization. An attacker with write access to the pickle file or the ability to control log entries could achieve remote code execution.
Severity:
highFile:
src/art/langgraph/logging.pySolution
Replace pickle with a safe serialization format like JSON, msgpack, or protobuf. If pickle must be used, implement integrity verification (e.g., HMAC) and restrict file permissions. Consider using json.dump/json.load instead of pickle.dump/pickle.load.
Changes
src/art/langgraph/logging.py(modified)Testing