Decouple Megatron paths and centralize chat-template defaults#686
Open
Kovbo wants to merge 4 commits into
Open
Decouple Megatron paths and centralize chat-template defaults#686Kovbo wants to merge 4 commits into
Kovbo wants to merge 4 commits into
Conversation
26edd52 to
a2019a6
Compare
a2019a6 to
8014898
Compare
3e9733c to
7aa3be3
Compare
824d471 to
63945e6
Compare
63945e6 to
ad1d5a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
art.megatron.serviceat module import time, so Megatron service helpers can load in Megatron-only environmentscreate_identity_lorausable without TRL/vLLM side imports by using a local GC/CUDA cleanup helperunsloth_zoodependency from SFT tokenization by adding ART-owned response-only label masking inart.preprocessing.response_maskingtywhen kwargs are passed totokenizer.apply_chat_templateTesting
uv run --with ruff ruff check src/art/megatron/service.pyuv run ruff check src/art/utils/chat_template.py src/art/preprocessing/tokenize.py src/art/preprocessing/response_masking.py tests/unit/test_preprocessing_tokenize.pyuv run ty check src/art/utils/chat_template.py src/art/preprocessing/tokenize.py src/art/tinker/server.pyPYTHONPATH=/tmp/art-serverless-fix/src:/tmp/art-serverless-fix/tests uv run pytest /tmp/art-serverless-fix/tests/unit/test_preprocessing_tokenize.py -qPYTHONPATH=/tmp/art-serverless-fix/src uv run python - <<'PY'from art.megatron.service import create_identity_loraprint(create_identity_lora.__name__)PYQwen/Qwen3-30B-A3B-Instruct-2507with rank 1