P36.7#17
Merged
Merged
Conversation
GetActiveSeason() now filters AND start_time <= GETUTCDATE() so a future-dated active season is invisible until its scheduled start. Defence-in-depth backstops added in RefreshCache(), RecordActivity(), and OnCharacterLogin() to guard StartTime alongside the existing EndTime checks. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
…uard mark-delivered on reward failure Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
A DB error during one player's delivery (e.g. failed INSERT) would abort the loop and silently skip all subsequent players. Wrap the per-player block in both ProcessSeasonEnd and RedeliverLeaderboardRewards with a try/catch so a single failure is logged and the loop continues. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
…cycle GetPendingRecurringSeason lacked an end_time guard, so the already-ended previous season matched the query after deactivation (is_active=0, is_recurring=1, start_time<=now). RefreshCache reactivated it every 5 min, ProcessSeasonEnd ran again, and another clone was created indefinitely. Fix: add AND end_time > GETUTCDATE() to the query so ended seasons are never treated as pending. Add HasFutureClone() as defence-in-depth guard in ProcessSeasonEnd so no second clone is created even if the method fires twice. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.