Skip to content

OcdFileExport: Harmonize warning messages#2245

Draft
dl3sdo wants to merge 1 commit into
OpenOrienteering:masterfrom
dl3sdo:consistent-export-warnings
Draft

OcdFileExport: Harmonize warning messages#2245
dl3sdo wants to merge 1 commit into
OpenOrienteering:masterfrom
dl3sdo:consistent-export-warnings

Conversation

@dl3sdo

@dl3sdo dl3sdo commented Jun 21, 2024

Copy link
Copy Markdown
Member

Warning messages were not consistent regarding whether

  • the symbol name is quoted (text symbols were unquoted)
  • they end with a dot
  • details are separated by a comma or a colon

Warning messages were not consistent regarding whether
- the symbol name is quoted (text symbols were unquoted)
- they end with a dot
- details are separated by a comma or a colon
@dl3sdo

dl3sdo commented Jun 21, 2024

Copy link
Copy Markdown
Member Author

Regarding consistency:
.ocd import has a different style, e.g.
In line symbol 862.0 'Treppe': Skipped secondary point symbol.

@dg0yt

dg0yt commented Jun 22, 2024

Copy link
Copy Markdown
Member
  • This affects translations. Without manual edits, existing translations are no longer used, immediately.
  • OcdFileImport has overloads addSymbolWarning for (OCD) symbol types which use per-type variants of "In area symbol %1 '%2': %3" to decouple the repeated text from the individual details. Maybe this is a pattern to adopt and adopt in other places.

@dl3sdo dl3sdo marked this pull request as draft June 22, 2024 11:16
@dg0yt dg0yt added this to the v0.9.6+1 milestone Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants