[com1]: make deposition erodable (initially)#1292
Conversation
|
Coverage Impact ⬆️ Merging this pull request will increase total coverage on Modified Components (1)
Modified Files with Diff Coverage (4)
🤖 Increase coverage with AI coding...🚦 See full report on Qlty Cloud » 🛟 Help
|
| fields : dict | ||
| fields dictionary |
There was a problem hiding this comment.
I think it could be interesting to provide a list of the fields that are needed and what they mean, e.g. FTDet, etc.
| adaptSfcEntrainment = 0 | ||
| # deposition is only entrainable if adaptSfcStopped = 1 and adaptSfcEntrainment = 1 | ||
| # then mass that is stopped can be entrained (also if the entrainment area is not in this stopped area) | ||
| entrainableDeposition = False |
There was a problem hiding this comment.
this is a nested logic - is there a check and error message if it is true but the others are False?
There was a problem hiding this comment.
is it better to raise an error or to set entrainableDeposition to False in this case (as it is done in com1DFA.py line 3464)?
| adaptSfcStopped = 0 | ||
| adaptSfcDetrainment = 0 | ||
| adaptSfcEntrainment = 0 | ||
| # deposition is only entrainable if adaptSfcStopped = 1 and adaptSfcEntrainment = 1 |
There was a problem hiding this comment.
and if it is an entrainment simulation - consider adding this info

add an option that deposition is entrainable: (if
ent in simTypeList, adaptSfcStopped = 1, adaptSfcEntrainment = 1, entrainableDeposition = True)erodible layer:$h_{entrainable}$ ist die Höhe, nicht Mächtigkeit!!!)
(
before simulation:
$dem_{notEntrainable} = dem_{orig} - h_{entrainable}(t=0)$
for every timestep t and for every grid cell:
($\rho$ : density of flowing material, $thickness$ is derived from $h$ and slope)
closes Do we need on top of the topography an erodible layer? DebrisFrame#68
closes make deposited material erodible DebrisFrame#69
there are still a many open questions:
[com1]: improve adaptable topography DebrisFrame#66
fixes bugs, when using timedependent release and entrainment:
closes Test all variations (ent, res, sec release) with time dependent release DebrisFrame#74