Skip to content

[com1]: make deposition erodable (initially)#1292

Open
PaulaSp3 wants to merge 10 commits into
masterfrom
PS_addErodibleLayer
Open

[com1]: make deposition erodable (initially)#1292
PaulaSp3 wants to merge 10 commits into
masterfrom
PS_addErodibleLayer

Conversation

@PaulaSp3

@PaulaSp3 PaulaSp3 commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

@PaulaSp3 PaulaSp3 requested review from awirb and fso42 June 10, 2026 11:35
@PaulaSp3 PaulaSp3 self-assigned this Jun 10, 2026
@PaulaSp3 PaulaSp3 added enhancement New feature or request DebrisFrame labels Jun 10, 2026
@PaulaSp3 PaulaSp3 requested a review from JuLa96 June 10, 2026 11:39
@qltysh

qltysh Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Qlty


Coverage Impact

⬆️ Merging this pull request will increase total coverage on master by 0.04%.

Modified Components (1)

RatingComponent% Diff
Coverage rating: C Coverage rating: C
com1DFA94.1%

Modified Files with Diff Coverage (4)

RatingFile% DiffUncovered Line #s
Coverage rating: B Coverage rating: B
avaframe/com1DFA/com1DFA.py96.9%1314
Coverage rating: A Coverage rating: A
avaframe/out3Plot/plotUtils.py100.0%
Coverage rating: B Coverage rating: B
avaframe/com1DFA/deriveParameterSet.py50.0%906
Coverage rating: A Coverage rating: A
avaframe/in3Utils/geoTrans.py100.0%
Total97.5%
🤖 Increase coverage with AI coding...
In the `PS_addErodibleLayer` branch, add test coverage for this new code:

- `avaframe/com1DFA/com1DFA.py` -- Line 1314
- `avaframe/com1DFA/deriveParameterSet.py` -- Line 906

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

Comment thread avaframe/com1DFA/com1DFA.py
Comment on lines 3873 to 3874
fields : dict
fields dictionary

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it could be interesting to provide a list of the fields that are needed and what they mean, e.g. FTDet, etc.

adaptSfcEntrainment = 0
# deposition is only entrainable if adaptSfcStopped = 1 and adaptSfcEntrainment = 1
# then mass that is stopped can be entrained (also if the entrainment area is not in this stopped area)
entrainableDeposition = False

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a nested logic - is there a check and error message if it is true but the others are False?

@PaulaSp3 PaulaSp3 Jun 12, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it better to raise an error or to set entrainableDeposition to False in this case (as it is done in com1DFA.py line 3464)?

adaptSfcStopped = 0
adaptSfcDetrainment = 0
adaptSfcEntrainment = 0
# deposition is only entrainable if adaptSfcStopped = 1 and adaptSfcEntrainment = 1

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and if it is an entrainment simulation - consider adding this info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DebrisFrame enhancement New feature or request

Projects

None yet

2 participants