refactor(drivers/139): update path handling, put for family/group - #2719
Merged
Conversation
xrgzs
force-pushed
the
fix/139-family
branch
5 times, most recently
from
July 6, 2026 13:02
e109087 to
d1c2368
Compare
xrgzs
changed the title
xrgzs
marked this pull request as ready for review
July 6, 2026 13:59
xrgzs
marked this pull request as draft
July 16, 2026 15:20
Signed-off-by: MadDogOwner <[email protected]>
Signed-off-by: MadDogOwner <[email protected]>
Signed-off-by: MadDogOwner <[email protected]>
Signed-off-by: MadDogOwner <[email protected]>
Signed-off-by: MadDogOwner <[email protected]>
Signed-off-by: MadDogOwner <[email protected]>
Signed-off-by: MadDogOwner <[email protected]>
Signed-off-by: MadDogOwner <[email protected]>
Signed-off-by: MadDogOwner <[email protected]>
- Wrap stream with LimitedUploadStream before creating StreamSectionReader - Aligns with the same pattern used in the MetaPersonal/MetaGroup/MetaFamily path Co-authored-by: GitHub Copilot <[email protected]>
- Check rd.Seek() return value and free the section reader on error - Call ss.FreeSectionReader(rd) on all error paths within retry.Do closure - Prevents buffer.Block leak when retrying failed upload chunks Co-authored-by: GitHub Copilot <[email protected]> Signed-off-by: MadDogOwner <[email protected]>
- Move ss.GetSectionReader() before retry.Do() so the sequential stream section reader is only called once per chunk - Remove redundant ss.FreeSectionReader() calls from inside the retry closure since the reader is now owned by the outer scope - Fixes 'stream not cached' errors when retrying failed chunk uploads during cross-storage WebDAV COPY operations Co-authored-by: GitHub Copilot <[email protected]>
- Add UseOldStreamUpload option - Implement newRequest, newPost - Support rapid upload for PersonalNew and Group/Family Signed-off-by: MadDogOwner <[email protected]>
Signed-off-by: MadDogOwner <[email protected]>
Signed-off-by: MadDogOwner <[email protected]>
Signed-off-by: MadDogOwner <[email protected]>
Signed-off-by: MadDogOwner <[email protected]>
xrgzs
marked this pull request as ready for review
July 21, 2026 08:19
Member
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cd91c64340
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- Pass the global partInfos slice instead of the batch subset to uploadPersonalParts, so that PartNumber-1 indexing does not go out of bounds when a file has more than 100 parts. Co-authored-by: Codex <[email protected]>
- Save p.Done before each part and reset it inside the retry function so that bytes from failed attempts are not counted toward progress. - Each part is counted exactly once, on the successful attempt. Co-authored-by: Codex <[email protected]>
- Only validate GroupCloudHost and FamilyCloudHost for MetaGroup and MetaFamily storage types, so that personal-only accounts do not fail initialization when the route policy omits group/family. Co-authored-by: Codex <[email protected]>
Signed-off-by: MadDogOwner <[email protected]>
Signed-off-by: MadDogOwner <[email protected]>
7 tasks
Signed-off-by: MadDogOwner <[email protected]>
…zation Signed-off-by: MadDogOwner <[email protected]>
xrgzs
changed the title
jyxjjj
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary / 摘要
说明：
官方网页版家庭云/共享群的上传方法已经改成与（新）个人云的一致，只是域名不同，已预留API URL地址请求函数，
但老方法仍能上传，暂未实现新方法。实测老方法上传大文件会有问题，上传速度可能不如新方法。 故统一为新方法。新方法支持秒传，但不支持流式，因此添加开关，允许用户回退到「旧版本的流式上传」。出现这个问题是官方家庭云改用
root:/前缀，之前不会拼接 root，故产生此问题。由于相关字段中包含 ID，因此使用拼接方法，不将ID直接改为Path，降低迁移成本。目前官方共享群未使用
root:/前缀，后续如果改了，直接改dirPath函数即可。/ 此 PR 包含破坏性变更。
/ 此 PR 修改了公开 API、配置、存储格式或迁移行为。
/ 此 PR 需要关联仓库同步修改。
Related repository PRs / 关联仓库 PR:
Related Issues / 关联 Issue
Testing / 测试
go test ./...家庭云 上传 复制 移动 删除 重命名 新建文件夹，根目录和子目录均无问题
修改到的新个人云测试上传无问题
Checklist / 检查清单
/ 我已阅读 CONTRIBUTING。
/ 我确认此贡献符合仓库许可证、贡献规范和行为准则。
gofmt,go fmt, orprettierwhere applicable./ 我已按适用情况使用
gofmt、go fmt或prettier格式化变更代码。/ 我已在适用情况下请求相关维护者或代码所有者审查。
AI Disclosure / AI 使用声明
/ 此 PR 包含 AI 辅助内容。
Tools used / 使用工具:
Usage scope / 使用范围:
Code generation / 代码生成
Refactoring / 重构
Documentation / 文档
Tests / 测试
Translation / 翻译
Review assistance / 审查辅助
I have reviewed and validated all AI-assisted content included in this PR.
/ 我已审核并验证此 PR 中的所有 AI 辅助内容。
I have ensured that all AI-assisted commits include
Co-Authored-Byattribution./ 我已确保所有 AI 辅助提交都包含
Co-Authored-By归属信息。I can reproduce all AI-assisted content included in this PR without any AI tools.
/ 我可以在没有任何 AI 工具的情况下重现此 PR 中包含的所有 AI 辅助内容。