Skip to content

fix(acp): mirror Claude Opus 5 models from software-agent-sdk - #320

Open
nicolasdmolina wants to merge 4 commits into
OpenHands:mainfrom
nicolasdmolina:fix/claude-opus-5-acp-model
Open

fix(acp): mirror Claude Opus 5 models from software-agent-sdk#320
nicolasdmolina wants to merge 4 commits into
OpenHands:mainfrom
nicolasdmolina:fix/claude-opus-5-acp-model

Conversation

@nicolasdmolina

@nicolasdmolina nicolasdmolina commented Aug 1, 2026

Copy link
Copy Markdown

HUMAN:
This PR proposes to update typescript-client inline with the model registry merged previously in agent-sdk.

Summary

Mirrors the final Claude Code ACP model registry from OpenHands/software-agent-sdk#4326, which is merged.

  • label the version-neutral aliases as:
    • opus[1m]Claude Opus (1M)
    • sonnetClaude Sonnet
    • haikuClaude Haiku
  • add the explicit claude-opus-5 pin → Claude Opus 5
  • keep default_model: opus[1m]

The short aliases are provider- and account-dependent, so version-neutral labels avoid going stale; the explicit claude-opus-5 entry remains available for users who want to pin Opus 5.

Agent Canvas reads this registry via @openhands/typescript-client, so this mirror keeps the model picker aligned with the merged SDK behavior.

HUMAN:

  • Ran npm ci, npx prettier --check src/models/acp-providers.json, and npm test -- --runInBand src/__tests__/acp-providers.test.ts on the updated branch and confirmed expected model entries and checks pass.

Test plan

  • scripts/check-acp-drift.py matches merged SDK #4326 (merge commit abeb884c)
  • npm ci (includes the TypeScript build)
  • npx prettier --check src/models/acp-providers.json
  • npm test -- --runInBand src/__tests__/acp-providers.test.ts
  • After publish + Agent Canvas bump: the model dropdown shows the version-neutral aliases and explicit Claude Opus 5 pin

Relabel opus[1m] to Claude Opus 5 (1M), add claude-opus-5 pin, and refresh
the Sonnet alias label to Sonnet 5 so Agent Canvas matches the SDK registry.
@nicolasdmolina

Copy link
Copy Markdown
Author

@neubig The mirror now matches the final labels from merged OpenHands/software-agent-sdk#4326, and the ACP drift check plus focused client validation pass locally. Could you review and approve the fork workflow run when convenient?

@nicolasdmolina

Copy link
Copy Markdown
Author

Friendly nudge — this is ready for review when you have a moment.

@enyst enyst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@enyst

enyst commented Aug 15, 2026

Copy link
Copy Markdown
Member

@nicolasdmolina Sorry for the delay on this PR. I see CI is failing on this: https://github.com/OpenHands/typescript-client/actions/runs/31886064565/job/95015449401?pr=320 Do you know why?

@OpenHands OpenHands deleted a comment from all-hands-bot Aug 15, 2026
@all-hands-bot

Copy link
Copy Markdown
Contributor

🚦 CI is currently failing on this PR's latest commit.

Please fix the failing checks before OpenHands reviews it - this is re-checked automatically once you push a new commit. (A maintainer can also request @all-hands-bot as a reviewer to have it reviewed regardless of CI status.)

This is an automated check - no AI was used to generate this comment.

@nicolasdmolina

Copy link
Copy Markdown
Author

I fixed the CI drift failures in this PR on commit d0f772d (): updated src/models/acp-providers.json to @agentclientprotocol/[email protected] and @agentclientprotocol/[email protected]; updated src/tests/acp-providers.test.ts to expect [email protected]. I verified with local checks: npm test -- --runInBand src/tests/acp-providers.test.ts and scripts/check-acp-drift.py against the linked SDK commit both pass. Endpoint Audit is still failing with from the existing run.

@nicolasdmolina

Copy link
Copy Markdown
Author

I fixed the CI drift failures in this PR on commit d0f772d ("fix(ci): align ACP providers with sdk drift target"): updated src/models/acp-providers.json to @agentclientprotocol/[email protected] and @agentclientprotocol/[email protected], and updated src/tests/acp-providers.test.ts to expect [email protected]. I also verified locally that npx prettier --check and npm test -- --runInBand src/tests/acp-providers.test.ts pass, and scripts/check-acp-drift.py passes against the linked SDK commit. Endpoint Audit remains blocked by "Resource not accessible by integration".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants