Presidio fail-loud: surface NER degradation instead of silent regex fallback#18
Merged
Conversation
…t regex fallback If the .presidio marker is set (NER expected) but Presidio/spaCy fails to import or warm up, the bridge silently fell back to the regex scrubber -- which with an empty denylist scrubs NO names. Only signal was a log line. For a privacy tool that's the dangerous failure mode. Now the bridge proves NER works at startup and, if not, writes a .presidio_failed marker (and logs loudly); bin/ghost surfaces it in the status line (⚠️ NER scrubber OFF). The marker is cleared on success / when NER isn't expected. Tests -> 34.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review finding 1.4. If
.presidiois set (NER expected) but Presidio/spaCy fails to import or warm up, the bridge silently fell back to the regex scrubber -- which, with an empty denylist, scrubs no names. The only signal was a log line. For a privacy tool that's the dangerous quiet-failure mode.Now the bridge verifies NER actually works at startup; if not, it writes a
.presidio_failedmarker (and logs loudly), andbin/ghostsurfaces it in the status line (⚠️ NER scrubber OFF (regex fallback)). Cleared on success / when NER isn't expected.pytest tests/-> 34 pass; verified live (NER active -> no marker, status clean).