Skip to content

Clamp Amiga palette copy size to destination capacity #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
segrax merged 1 commit into from
May 24, 2026
Merged

Clamp Amiga palette copy size to destination capacity #115

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions Source/Amiga/Graphics_Amiga.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,8 +391,11 @@ void cGraphics_Amiga::Load_And_Draw_Image(const std::string& pFilename, unsigned
Decoded.mDimension.mHeight = 0x101;
}

// Load the palette
Decoded.CopyPalette(mPalette, (1LL << Decoded.mPlanes));
// Load the palette (clamped to avoid overflow/UB from file-controlled plane counts)
const size_t PaletteCapacity = sizeof(mPalette) / sizeof(mPalette[0]);
const size_t PlaneCount = static_cast<size_t>(Decoded.mPlanes);
const size_t RequestedColors = (PlaneCount < (sizeof(size_t) * 8)) ? (1ULL << PlaneCount) : PaletteCapacity;
Decoded.CopyPalette(mPalette, std::min(RequestedColors, PaletteCapacity));

mBMHD_Current = Decoded.GetHeader();

Expand Down
Loading