Skip to content

Disable concurrency for sync mode webhook triggers#4570

Open
taylordowns2000 wants to merge 6 commits into
mainfrom
claude/disable-concurrency-sync-mode-it1W8
Open

Disable concurrency for sync mode webhook triggers#4570
taylordowns2000 wants to merge 6 commits into
mainfrom
claude/disable-concurrency-sync-mode-it1W8

Conversation

@taylordowns2000

@taylordowns2000 taylordowns2000 commented Mar 26, 2026

Copy link
Copy Markdown
Member

Description

Closes #4569

This PR adds a label to warn about the strange behaviour of sync-mode triggers, with respect to concurrency. When a webhook trigger is configured with sync mode, most OpenFn instances ignore the limit.

image

Validation steps

  1. Create or edit a workflow with a webhook trigger configured in sync (response) mode
  2. Verify the informational message appears below the input
  3. Switch the webhook trigger to async mode and verify the info text is gone

AI Usage

  • I have used Claude Code
  • I have used another model
  • I have not used AI

Pre-submission checklist

  • I have performed an AI review of my code (we recommend using /review with Claude Code)
  • I have implemented and tested all related authorization policies. (e.g., :owner, :admin, :editor, :viewer)
  • I have updated the changelog.
  • I have ticked a box in "AI usage" in this PR

@github-project-automation github-project-automation Bot moved this to New Issues in Core Mar 26, 2026
@codecov

codecov Bot commented Mar 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.51%. Comparing base (e087a5b) to head (1373fcb).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4570      +/-   ##
==========================================
+ Coverage   89.49%   89.51%   +0.01%     
==========================================
  Files         441      441              
  Lines       21111    21111              
==========================================
+ Hits        18894    18897       +3     
+ Misses       2217     2214       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@taylordowns2000 taylordowns2000 marked this pull request as draft March 26, 2026 14:31
claude and others added 2 commits June 10, 2026 12:42
When a workflow's trigger uses sync/response mode (webhook_reply:
after_completion), the concurrency setting is not respected, so we
disable the input and show an info icon tooltip plus explanatory text.

https://claude.ai/code/session_01A2Cryi5yc1wWpYiS1tT5E8
@taylordowns2000 taylordowns2000 force-pushed the claude/disable-concurrency-sync-mode-it1W8 branch from cd51f09 to 48b9dc6 Compare June 10, 2026 10:42
@taylordowns2000 taylordowns2000 marked this pull request as ready for review June 10, 2026 11:20
@github-actions

Copy link
Copy Markdown

Security Review ✅

  • S0 (project scoping): N/A — UI-only change in WorkflowSettings.tsx reads existing triggers from the workflow store; no new queries or web-layer entrypoints.
  • S1 (authorization): N/A — no new actions; concurrency input remains gated by the existing isReadOnly check and the change only adds conditional help text.
  • S2 (audit trail): N/A — no writes to config resources; this purely changes how an explanatory message is rendered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: New Issues

Development

Successfully merging this pull request may close these issues.

UI makes it seem like concurrency settings work for sync-mode workflows

2 participants