QS tab: Carlos' suggestions (#59) — stacked signals, fit-channel excludes, custom signals#82
Open
logan-nc wants to merge 3 commits into
Open
QS tab: Carlos' suggestions (#59) — stacked signals, fit-channel excludes, custom signals#82logan-nc wants to merge 3 commits into
logan-nc wants to merge 3 commits into
Conversation
Thread a `fit_exclude` query param through _prep_qs_ds → _qs_run (cache key) → run_steps(fit_kwargs) → fit.fit(), anchored+escaped for literal channel matches. It only affects the fit, so excluded channels stay in `prepared` (the GUI greys them on the sensor maps rather than dropping them). Add a custom-signal path: `raw_pointnames` on fetch_shot pulls arbitrary PTDATA pointnames verbatim and merges them into an existing shot HDF5 (plumbed through the --pointnames CLI and run_remote for the cluster path); a `signals` field on FetchRequest wires it to /api/fetch; a new `extra_signals` node serves the merged signals as one series each, with found/missing reported in meta. Co-Authored-By: Claude Opus 4.8 <[email protected]>
Promote the raw+prepared sensor-signals plot into its own section with an overlay⇄stack toggle (one tightly-packed axes per sensor; only the bottom axes labels the time axis). Add a collapsed "fit channels" checkbox panel whose deselections ride the deferred Plot commit as `fit_exclude` and grey the excluded sensors on the R-Z and phi-theta maps. Add a collapsed custom-signal panel above the sensor signals: fetch a list of pointnames (streamed progress) into the shot's HDF5, then plot each via the `extra_signals` node in its own axes. Lift backend/credentials into a shared `fetchCreds` store slice so PullControl and the panel share one entry. Co-Authored-By: Claude Opus 4.8 <[email protected]>
Collaborator
Author
|
Nice sensor selection with visual aid: |
Collaborator
Author
|
Default sensor data overlay: Stacked sensor data: |
Custom-signal names were all fetched via ptdata2, but EFIT scalars like betan / li / q95 aren't PTDATA — they live in an MDSplus tree (\top.results.aeqdsk:<name>, same place kappa comes from), so ptdata2 returned nothing and they read back "missing". Add a `derived signals` catalog to the device file and split custom names into PTDATA pointnames vs tree signals (split_custom_signals), routing the listed EFIT scalars through the existing openTree→get fetch. Broaden the GUI help text to "signal names — PTDATA pointnames or EFIT scalars". Co-Authored-By: Claude Opus 4.8 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the three quasi-stationary tab items from #59.
Features
overlay ⇄ stack per sensortoggle — one tightly-packed axes per sensor, only the bottom axes labels the time axis. A single style legend (── prepared · ···· raw) covers the whole section.fit_excludequery param threads through_prep_qs_ds → _qs_run(cache key)→ run_steps(fit_kwargs) → fit.fit(), anchored +re.escape-d for literal matches. It only affects the fit, so excluded channels stay inpreparedand render greyed on the φ-θ map.raw_pointnamesonfetch_shotpulls arbitrary PTDATA pointnames verbatim and merges them into the shot HDF5 (plumbed through the--pointnamesCLI +run_remote); asignalsfield on/api/fetchand a newextra_signalsnode serve them, plotted one axes each. Input is validated (PTDATA pointname pattern) with a tooltip/help text and rejects malformed entries. Fetch is guarded on missing credentials (clear error + stall watchdog instead of an eternal 0%).Layout & polish
fetchCredsstore slice soPullControland the custom-signal panel share one entry.Verification
ruff format/tygreen. New tests coverfit_exclude(drops one fit channel, stays finite) andextra_signals(found/missing), at thebuild_nodeand HTTP-route layers.tsc/eslint clean, 27 vitest,vite buildOK.🤖 Generated with Claude Code