hbtep: add HBT-EP device config (PA1/PA2 arrays)#72
Open
logan-nc wants to merge 1 commit into
Open
Conversation
Adds data/device/hbtep.json so HBT-EP is a selectable, tree-based
(mdsplus_tree) device alongside DIII-D and NSTX. The device-generic
data/service layer needs no code changes: /api/devices auto-discovers it,
the toksearch tree path uses each sensor key as the fetch TDI, and
device_geom classifies Bp/Br from the sensor-set name.
The 96 PA1/PA2 poloidal-array sensors come from sensor_info_PA_Nominal.txt:
Cartesian (x,y,z) + unit normals converted to r/z/phi + authoritative
theta (and tilt). Keys are the \TOP.SENSORS.MAGNETIC:PA#_S##{P,R} tree
node paths; nodes return calibrated Tesla so gain=na=1; time base is
seconds. Sensor sets name the P arrays "Bp" and the R arrays "Br" so the
generic classifier tags them; each PA Bp set is a full 32-probe poloidal
contour (the SLCONTOUR/MODESPEC shape). first_wall/wall trace the PA1
sensor ring. plasma pointnames are omitted until confirmed on a live tree.
Co-Authored-By: Claude Opus 4.8 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
src/magnetics/data/device/hbtep.jsonso HBT-EP (Columbia's tokamak) is a selectable, tree-based (mdsplus_tree) device alongside DIII-D and NSTX/NSTX-U.The device-generic data/service layer needs no code changes:
/api/devicesauto-discovers the file, thetoksearchtree path uses each sensor key as the fetch TDI, anddevice_geomclassifies Bp/Br from the sensor-set name (the same path NSTX rides).What's in the config
sensor_info_PA_Nominal.txt(Levesque, 2011-09-14): Cartesian(x,y,z)+ unit normals converted tor/z/phi+ authoritativetheta(andtilt,R0=0.92).\TOP.SENSORS.MAGNETIC:PA#_S##{P,R}tree node paths; nodes return calibrated Tesla sogain=na=1; time base is seconds.first_wall/walltrace the PA1 sensor ring (approximate vessel contour); MDSplus atmaxwell.ap.columbia.edu:8003, treehbtep2.Tests
Adds
tests/test_hbtep_device.py(6 config-only checks: load, node-path keys, Bp/Br classification, two toroidal locations, geometry render + wall). Full suite: 310 passed, 5 skipped;ruff formatclean.Verified (offline)
/api/deviceslistshbtepwith all 7 sensor sets.device_geometry(shot, 'hbtep')→ 96 sensors, kinds{Bp, Br}, R ∈ [0.75, 1.08], 33-point wall.Open TODOs (documented in
geometry_note, non-blocking)plasma pointnames(ip/bt/kappa) omitted — onlyOH_CURRENT's path was known; a wrong guess breaks fetch, and QS's κ-fallback covers absence.phifollows the source(x,y); revisit the sign if a downstream n-number comes out flipped.maxwell.ap.columbia.edu:8003(on-site/tunneled) not yet exercised.🤖 Generated with Claude Code