fix(web): remediate GUI Crucible findings (a11y, honesty, states, perf)#62
Open
jungdaesuh wants to merge 1 commit into
Open
fix(web): remediate GUI Crucible findings (a11y, honesty, states, perf)#62jungdaesuh wants to merge 1 commit into
jungdaesuh wants to merge 1 commit into
Conversation
Adopts the existing theme.css token system; minimal token-driven diffs. - Perf: per-field useStore selectors so the shell no longer re-renders on every time-cursor scrub. - Honesty: the "live backend" badge keys off the backend's per-machine `mock` flag (was !!API_BASE, which reads "live" over a mock machine list); RotatingTab label follows suit. Adds mock?: boolean to MachineInfo. - UI states: SensorsTab empty state for incomplete geometry meta; RotatingTab "computing mode map…" placeholder + persistent scrubber while mode_number loads; ErrorBoundary retry; PullControl shot validation (+ inputMode/aria-invalid); equilibrium control disabled + "(coming soon)" while its node is absent (#43). - a11y: keyboard-operable tabs / shot list / resize divider / collapse headers; aria-pressed toggles; slider labels; role=status/aria-live + progressbar on the live-pull progress. - Docs/tests: qsTransforms.phiPeak docstring corrected (signed argmax is intentional) + signed-vs-|·| test; ErrorBoundary retry test; cross-tab theme-sync store listener + tests. Frontend 28 tests pass; lint/typecheck/build green. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remediates the confirmed GUI findings from an adversarial (Crucible) review —
accessibility, honesty of the live/mock signal, missing UI states, and a re-render
perf issue. Adopts the existing
theme.csstoken system; minimal token-driven diffs.Related issue
Relates to #43 — the equilibrium overlay control is disabled/"(coming soon)" until
its backend node lands; the contract branch is intentionally retained.
Type of change
src/magnetics/core)src/magnetics/data)src/magnetics/service)gui/web)What changed
useStoreselectors so the shell no longer re-renders on everytime-cursor scrub (App didn't read
cursorMs).mockflag(was
!!API_BASE, which reads "live" over a mock machine list); RotatingTab'sdata-source label follows suit. Adds
mock?: booleantoMachineInfo."computing mode map…" placeholder + persistent scrubber while the heavy
mode_numberSTFT loads; ErrorBoundary retry; PullControl shot validation (+
inputMode/aria-invalid); equilibrium control disabled + "(coming soon)" (Add real equilibrium (LCFS / flux-surface) plotting to the Sensors view #43).headers;
aria-pressedtoggles; slider labels;role=status/aria-live+role=progressbaron the live-pull progress.qsTransforms.phiPeakdocstring corrected (signed argmax is theintended, physically-correct behavior) + a signed-vs-
|·|test; ErrorBoundary retrytest; cross-tab theme-sync store listener + tests.
How I tested it
In
gui/web:npm run lint/npm run typecheck/npm test(28 passed) /npm run build→ all green. (The >500 kB chunk warning is pre-existing/plotly.)Checklist
ruff+pytest; web:lint+build) — validated locallycore(device-agnostic); none added to service routes🤖 Generated with Claude Code