Replace Devlooped.CredentialManager with Microsoft.AspNetCore.DataProtection.Extensions#20
Open
yungcomputerchair wants to merge 2 commits into
Open
Conversation
…tection.Extensions
Contributor
Author
|
@StimpyDev can you test on Windows without Git please :) |
StimpyDev
reviewed
Jul 12, 2026
| } | ||
| } | ||
|
|
||
| private static Dictionary<string, string> Load() |
Contributor
There was a problem hiding this comment.
Consider wrapping Load() in try/catch if passwords.dat is corrupt, log a warning and return an empty dictionary so the launcher keeps working.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Devlooped.CredentialManager misled me: it has a hard dependency on Git, so it doesn't work for end-users.
This PR switches to the cross-platform Microsoft.AspNetCore.DataProtection.Extensions package and encrypts a JSON password store at rest in the user's app data folder.
Same CredentialHelper interface, so no other code changes needed; migration from pre-v1.1.1 will still work