Fix Remember Password on Windows without Git#18
Closed
StimpyDev wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
Oh wait, i just noticed. I dont have git installed so that's why it didnt save, this change is for users without git installed. U can add the wincredman store back, whoops, i'm so dumb |
Contributor
|
This still stores the password in plaintext on disk, no? This stupid package was supposed to work without Git in the first place. Idk why it keeps falling back |
Contributor
Author
|
It makes a .password file with your password once u saved it, but encrypted |
Contributor
Author
|
I will be closing this pr, because your fix works just not for users without git installed and since i've added a check in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Actually fixes remember password on windows and prevents an unnecessary GCM attempt and a log warning every time the launcher starts on windows.