Skip to content

Fix Remember Password on Windows without Git#18

Closed
StimpyDev wants to merge 1 commit into
Open-Source-Free-Realms:mainfrom
StimpyDev:password-fix
Closed

Fix Remember Password on Windows without Git#18
StimpyDev wants to merge 1 commit into
Open-Source-Free-Realms:mainfrom
StimpyDev:password-fix

Conversation

@StimpyDev

Copy link
Copy Markdown
Contributor

Actually fixes remember password on windows and prevents an unnecessary GCM attempt and a log warning every time the launcher starts on windows.

@StimpyDev

StimpyDev commented Jul 11, 2026

Copy link
Copy Markdown
Contributor Author

Oh wait, i just noticed. I dont have git installed so that's why it didnt save, this change is for users without git installed. U can add the wincredman store back, whoops, i'm so dumb

@yungcomputerchair

Copy link
Copy Markdown
Contributor

This still stores the password in plaintext on disk, no?

This stupid package was supposed to work without Git in the first place. Idk why it keeps falling back

@StimpyDev

StimpyDev commented Jul 11, 2026

Copy link
Copy Markdown
Contributor Author

It makes a .password file with your password once u saved it, but encrypted

@StimpyDev

StimpyDev commented Jul 11, 2026

Copy link
Copy Markdown
Contributor Author

I will be closing this pr, because your fix works just not for users without git installed and since i've added a check in CreateStore it will always skips gcm, what we did for the crash fix we should also do that for the password. No git installed? Make the .password file

@StimpyDev StimpyDev closed this Jul 11, 2026
@StimpyDev StimpyDev deleted the password-fix branch July 11, 2026 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants