Fix 'Remember Password' on computers without Git installed#17
Merged
yungcomputerchair merged 1 commit intoJul 11, 2026
Merged
Conversation
yungcomputerchair
left a comment
yungcomputerchair
left a comment
Contributor
Author
There was a problem hiding this comment.
Can't get more broken :P
yungcomputerchair
merged commit e863a2b
into
Open-Source-Free-Realms:main
1 check passed
Contributor
|
Do u even test your code, this doesn't work |
Contributor
Author
I don't have a Win-x64 machine 😭😭😭 don't bully me Stimpy |
Contributor
|
Sorry bro im watching the world cup match between norway and england xD |
Contributor
Author
Same lol. I have one person saying it worked for them and another saying it didn't, so we probably need to look into this more. But the worst case scenario seems to be that the password just isn't saved, which imo is better than storing plaintext. What behavior did you see when you tried it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The credential package falls back to GCM if the
GCM_CREDENTIAL_STOREenvironment variable isn't set, and that defers togit.exeto lookup which credential manager to use. This throws (and we now catch it) but breaks password storage.The fix is to explicitly set the environment variable to the correct GCM.