Migrate + store passwords in OS credential store instead of server info XML#12
Merged
yungcomputerchair merged 2 commits intoJul 11, 2026
Conversation
I forgot that I refactored the credential layer to be a helper instead of a service, so this renames + puts it in the right spot.
Contributor
Author
|
Auto-merging in the interest of security |
yungcomputerchair
merged commit acbdc8d
into
Open-Source-Free-Realms:main
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remembered passwords are currently stored in plaintext on disk :(
This PR:
Devlooped.CredentialManagerpackage for easy access to the OS credential managerCredentialHelperthat securely stores passwords for each server into the OS credential manager instead of storing them in the server info XML