Expose DFTB modes, diagnostics, and ABI-aware integration#277
Expose DFTB modes, diagnostics, and ABI-aware integration#277karmachoi wants to merge 4 commits into
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 346084274e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| 'response_max_subspace': {'type': int, 'default': '100'}, | ||
| 'response_solver': {'type': string, 'default': 'auto'}, | ||
| # 0: quiet native kernels, 1: stages/summaries, 2: iteration detail. | ||
| 'print_level': {'type': int, 'default': '1'}, |
There was a problem hiding this comment.
Link the openqp-docs companion PR
This adds user-facing [dftb] controls such as print_level/state_to_state_spectrum and new public DFTB routes, but the commit text only links native openqp-dftb work and no openqp-docs PR. AGENTS.md rule 4 requires user-facing keywords/workflows to be documented in openqp-docs and the PR description to link that companion docs PR, so users will not have manual coverage for these new controls until that docs link/update is added.
Useful? React with 👍 / 👎.
Summary
job.dftb()MRSF defaultWhy
The OpenQP input surface and logs were centered on MRSF-TDDFTB, making the other DFTB families difficult to select and interpret. The adapter also accepted only newer C layouts, while installed ABI-1 libraries remain useful for their supported feature set. Finally, ABI number alone cannot distinguish older ABI-3 binaries from new binaries that add optional diagnostics without changing the state-gradient call signature.
User impact
dftb,tddftb,sf-tddftb, ormrsf-tddftbdirectly[dftb] type/[tdhf] typecombinations fail before calculationCompatibility
openqp-dftblibraryopenqp_dftb_capi_capabilities()means capability mask zero, including for older ABI-3 binariesValidation
gfortran-15+ Apple Accelerate:origin/mainbaseline2.647596e-13git diff --checkand Python byte-compilation passRelated work