Add procps package and fix release error and ordering#698
Merged
Conversation
oocube
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #696
Build job failed in GH Actions: https://github.com/mcarans/oolite/actions/runs/29538841631/job/87758292443. Changed release action to softprops/action-gh-release@v3 to fix.
Then noticed release assets not ordered correctly (1 appimage, then 3 win exes, then 2 appimages, then flatpaks; also deployment build not the first one for appimage and win) so fixed naming: see https://github.com/mcarans/oolite/releases/tag/1.93.1-procps.6 for new ordering (GitHub orders alphabetically so it's the best I could do given current filename structures and naming conventions.)
I think that in a future PR we should consider making test (the debug console enabled release) into the standard release and drop deployment unless there's an important reason to keep deployment or big disadvantage to always enabling the console such as performance. Happy for someone to tell me why we need deployment. It would simplify things to have 2 builds instead of 3.