readthedocs: remove sourcing of get_version.sh#697
Merged
Conversation
mcarans
requested review from
AnotherCommander,
Kaks,
KonstantinosSykas,
dsalt,
ericwalch,
jobi-wan,
kanthoney,
mwerle,
oocube and
phkb
as code owners
July 15, 2026 22:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #685
The readthedocs build started to work after the mk.sh PR was merged. Turns out the get_version.sh file correctly exits with:
❌ Parent process is sh, Bash parent is build_referencesheet_fn.sh. This file can only be called by meson or sourced by create_flatpak_fn.sh!
That error didn't cause the readthedocs build to fail, it just continued after the line sourcing get_version.sh and completed successfully. However, to prevent confusion better to remove the sourcing altogether as it's not needed.
A lot of explanation for deleting one line :-)