-
Notifications
You must be signed in to change notification settings - Fork 100
Adding gRPC / polling Tentacles over HTTPS information to existing documentation #3205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+14
−13
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
5186d91
Adding gRPC port to inbound port table
briggs-octo bb7b525
Adding initial Tentacle registration note to table for port 443
briggs-octo cf77426
Adding Polling Tentacles over HTTPS to HTTPS/port 443 row
briggs-octo 5140aec
Adding KLOS to installation components ports section
briggs-octo 613ca8f
Update mod date
briggs-octo 5990ca5
Updating mod date
briggs-octo 0240b13
Updating wording for TCP 443 row
briggs-octo 777e0f1
Fixing linter errors
briggs-octo 7cda0e4
Merge branch 'main' into briggs-octo-grpc-updates
briggs-octo 91dd813
Fixing spellcheck error
briggs-octo c661ba5
Fixing linter error
briggs-octo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I'm aware it's not required for Listening Tentacles because you register them on Octopus manually. You need to do this because Octopus generates the thumbprint. It's been a little while since I've setup a listening tentacle though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, you do need access to port 443 for Listening Tentacles as well. I was trying to figure out the best way to word that, which is why I had put Tentacle registration AND Polling Tentacles over websockets/HTTPS. This is needed for Listening Tentacles because of the
register-withcommand, like we show in our automation script here:https://octopus.com/docs/infrastructure/deployment-targets/tentacle/windows/automating-tentacle-installation#AutomatingTentacleinstallation-Example-ListeningTentacle