Revert " Add ReleaseNotes property support to IPackageSearchMetadata…#20
Draft
enf0rc3 wants to merge 1 commit into
Draft
Revert " Add ReleaseNotes property support to IPackageSearchMetadata…#20enf0rc3 wants to merge 1 commit into
enf0rc3 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We aim to reduce to number of features that we have implemented on our "fork" that is different from the "official" NuGet client.
This pr reverts commit e0a670b.
The PR that was reverted was responsible for adding the Release Notes to the response for V2 and V3 feeds.
When we re-forked the NuGet Client, 3.6 -> 6.14 the NuGet.Client stopped returning the release notes on the metadata for V3 Feeds.
To resolve this, for v3 feeds we opted to not depend on this method of fetching release notes, and instead implemented a different mechanism to fetch the release notes separately that does not use the NuGet.Client.
This means that Octopus Server now only uses the the ReleaseNotes on the IPackageMetadata for V2 feeds.