Backport SharpCompress removal from ConsolidateCalamariPackages to 2026.1#2012
Open
enf0rc3 wants to merge 2 commits into
Open
Backport SharpCompress removal from ConsolidateCalamariPackages to 2026.1#2012enf0rc3 wants to merge 2 commits into
enf0rc3 wants to merge 2 commits into
Conversation
APErebus
approved these changes
Jun 12, 2026
APErebus
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Just a friendly reminder to do a normal commit, not a squash 😃
borland
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
We want to bump/remove the vulnerable SharpCompress version in Octopus Server 2026.1, but cannot while
Calamari.ConsolidateCalamariPackagesstill depends on SharpCompress. That library is loaded in-process by Server, so a Server-side SharpCompress bump breaks it at runtime: the 0.x API renamedZipArchive.Open->OpenArchive, throwingMissingMethodException.The same problem was already resolved on 2026.2 / main by switching the library to
System.IO.Compression. This PR backports that work to 2026.1.Discussed in Slack: https://octopusdeploy.slack.com/archives/C03SG0LFJHX/p1781237251289469
Results
Straight cherry-picks (merge commits,
-m 1) of:ConsolidateCalamariPackagesfrom SharpCompress toSystem.IO.CompressionBoth are required and applied in order: #1913 alone ships the duplicate-file bug that #1926 fixes.
Note: the SharpCompress
<PackageReference>on 2026.1 carried a<NoWarn>NU1902</NoWarn>suppression that did not exist on main, so the cherry-pick could not auto-remove it. It was removed manually; the project csproj now matches main exactly.This is a self-contained Calamari change and does not require a corresponding Server change (per #1913). It unblocks the separate, planned Server SharpCompress bump.