Skip to content

Remove lsof command diagnostic#2005

Merged
adam-mccoy merged 1 commit into
mainfrom
bft/amc/remove-lsof
Jun 11, 2026
Merged

Remove lsof command diagnostic#2005
adam-mccoy merged 1 commit into
mainfrom
bft/amc/remove-lsof

Conversation

@adam-mccoy

Copy link
Copy Markdown
Contributor

This reverts #1683.

My understanding is that the diagnostic information provided by lsof hasn't proven useful in diagnosing the underlying issue. Executing this command produces hundreds of megabytes of output in task logs, the handling of which impacts test execution performance. If it's not providing value then it'd be best to remove it.

⚠️ Does this change require a corresponding Server Change?
⚠️ If so - please add a "Requires Server Change" label to this PR!

@adam-mccoy adam-mccoy requested a review from LukeButters June 10, 2026 06:16

@xwipeoutx xwipeoutx left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving - this hasn't come up on our team in my working memory, and Luke is on leave. We can revert this easily enough if we need to.

@adam-mccoy adam-mccoy merged commit 87fe9ee into main Jun 11, 2026
35 checks passed
@adam-mccoy adam-mccoy deleted the bft/amc/remove-lsof branch June 11, 2026 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants