Skip to content

Migrate to Contract classes for TargetDiscovery#2004

Merged
Jtango18 merged 5 commits into
mainfrom
jt/add-target-discovery-to-contracts
Jun 11, 2026
Merged

Migrate to Contract classes for TargetDiscovery#2004
Jtango18 merged 5 commits into
mainfrom
jt/add-target-discovery-to-contracts

Conversation

@Jtango18

Copy link
Copy Markdown
Contributor

⚠️ Does this change require a corresponding Server Change?
⚠️ If so - please add a "Requires Server Change" label to this PR!

Tipped off by the comment

    /// <summary>
    /// This type and the types it uses are duplicated here from Octopus.Core, because:
    /// a) There is currently no existing project to place code shared between server and Calamari, and
    /// b) We expect a bunch of stuff in the Sashimi/Calamari space to be refactored back into the OctopusDeploy solution soon.

This copies the Target Discovery files from Server and puts them in Calamari Contracts and replaces existing executions.

Ideally Server would be updated to leverage these instead of it's in-built classes too

@APErebus APErebus left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I'm assuming the Context is serialized into a variable as JSON and sent across

@Jtango18 Jtango18 merged commit 46174a0 into main Jun 11, 2026
34 of 35 checks passed
@Jtango18 Jtango18 deleted the jt/add-target-discovery-to-contracts branch June 11, 2026 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants