Skip to content

feat: added margin fee #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anuj-ondc wants to merge 2 commits into
base: release-TRV14-2.0.0
Choose a base branch
from
Open

feat: added margin fee #400

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32b1723
feat: added margin fee
anuj-ondc Jul 7, 2026
35eed68
feat: updated margin construct
anuj-ondc Jul 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
256 changes: 250 additions & 6 deletions api/build/build.yaml
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 4 additions & 0 deletions api/components/docs/changeLog/TRV14_2.0.0_100125.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,4 +184,8 @@
- Added support for operational hours in `location` field to capture opening hours, closing hours, and holiday schedules.
- Added mandatory city code in locations.

****27th July 2026****
- Added feature to charge margin fee
- Added ability for a seller to define mandatory fields either one of these two fields - Email, Mobile Number

---
10 changes: 10 additions & 0 deletions api/components/examples/unreserved-entry-pass/confirm/Confirm_ticket_booking.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,11 @@ message:
quantity:
selected:
count: 1
margin:

@92shreyansh 92shreyansh Jul 24, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have this as

{ "selected": { "measure": { "value": "10", "unit": "PERCENT" } }, "minimum": { "measure": { "value": "8", "unit": "PERCENT" } }, "maximum": { "measure": { "value": "10", "unit": "PERCENT" } } }

selected:
measure:
value: '10'
unit: PERCENT
add_ons:
- id: A1
quantity:
Expand All @@ -33,6 +38,11 @@ message:
quantity:
selected:
count: 1
margin:
selected:
measure:
value: '10'
unit: PERCENT
add_ons:
- id: A1
quantity:
Expand Down
2 changes: 1 addition & 1 deletion api/components/examples/unreserved-entry-pass/forms/additional_info.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
<input type="text" id="age" name="age"/>

<label for="email">Email ID</label>
<input type="text" id="email" name="email"/>
<input type="text" id="email" name="email" required/>

<label for="gender">Gender</label>
<select name="gender" id="gender">
Expand Down
10 changes: 10 additions & 0 deletions ...xamples/unreserved-entry-pass/init/Initialize_the_order_by_providing_billing_details.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,11 @@ message:
quantity:
selected:
count: 1
margin:
selected:
measure:
value: '10'
unit: PERCENT
add_ons:
- id: A1
quantity:
Expand All @@ -33,6 +38,11 @@ message:
quantity:
selected:
count: 1
margin:
selected:
measure:
value: '10'
unit: PERCENT
add_ons:
- id: A1
quantity:
Expand Down
10 changes: 10 additions & 0 deletions api/components/examples/unreserved-entry-pass/on_cancel/Cancel_ticket_booking_1.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,11 @@ message:
quantity:
selected:
count: 1
margin:
selected:
measure:
value: '10'
unit: PERCENT
time:
label: VALIDITY
duration: P2D
Expand Down Expand Up @@ -149,6 +154,11 @@ message:
quantity:
selected:
count: 1
margin:
selected:
measure:
value: '10'
unit: PERCENT
time:
label: VALIDITY
duration: P2D
Expand Down
10 changes: 10 additions & 0 deletions api/components/examples/unreserved-entry-pass/on_cancel/Cancel_ticket_booking_2.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,11 @@ message:
quantity:
selected:
count: 1
margin:
selected:
measure:
value: '10'
unit: PERCENT
time:
label: VALIDITY
duration: P2D
Expand Down Expand Up @@ -149,6 +154,11 @@ message:
quantity:
selected:
count: 1
margin:
selected:
measure:
value: '10'
unit: PERCENT
time:
label: VALIDITY
duration: P2D
Expand Down
10 changes: 10 additions & 0 deletions api/components/examples/unreserved-entry-pass/on_cancel/on_cancel_request_user_confirm.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,11 @@ message:
quantity:
selected:
count: 1
margin:
selected:
measure:
value: '10'
unit: PERCENT
time:
label: VALIDITY
duration: P2D
Expand Down Expand Up @@ -149,6 +154,11 @@ message:
quantity:
selected:
count: 1
margin:
selected:
measure:
value: '10'
unit: PERCENT
time:
label: VALIDITY
duration: P2D
Expand Down
10 changes: 10 additions & 0 deletions api/components/examples/unreserved-entry-pass/on_cancel/on_cancel_request_user_soft.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,11 @@ message:
quantity:
selected:
count: 1
margin:
selected:
measure:
value: '10'
unit: PERCENT
time:
label: VALIDITY
duration: P2D
Expand Down Expand Up @@ -149,6 +154,11 @@ message:
quantity:
selected:
count: 1
margin:
selected:
measure:
value: '10'
unit: PERCENT
time:
label: VALIDITY
duration: P2D
Expand Down
10 changes: 10 additions & 0 deletions api/components/examples/unreserved-entry-pass/on_cancel/on_cancel_unsolicited.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,11 @@ message:
quantity:
selected:
count: 1
margin:
selected:
measure:
value: '10'
unit: PERCENT
time:
label: VALIDITY
duration: P2D
Expand Down Expand Up @@ -149,6 +154,11 @@ message:
quantity:
selected:
count: 1
margin:
selected:
measure:
value: '10'
unit: PERCENT
time:
label: VALIDITY
duration: P2D
Expand Down
10 changes: 10 additions & 0 deletions ...served-entry-pass/on_confirm/Return_confirmed_ticket_order_with_payment_confirmation.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,11 @@ message:
quantity:
selected:
count: 1
margin:
selected:
measure:
value: '10'
unit: PERCENT
time:
label: VALIDITY
duration: P2D
Expand Down Expand Up @@ -149,6 +154,11 @@ message:
quantity:
selected:
count: 1
margin:
selected:
measure:
value: '10'
unit: PERCENT
time:
label: VALIDITY
duration: P2D
Expand Down
10 changes: 10 additions & 0 deletions ...ved-entry-pass/on_init/Return_draft_order_for_transit_ticket_with_settlement_details.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,11 @@ message:
quantity:
selected:
count: 1
margin:
selected:
measure:
value: '10'
unit: PERCENT
time:
label: VALIDITY
duration: P2D
Expand Down Expand Up @@ -147,6 +152,11 @@ message:
quantity:
selected:
count: 1
margin:
selected:
measure:
value: '10'
unit: PERCENT
time:
label: VALIDITY
duration: P2D
Expand Down
18 changes: 18 additions & 0 deletions ...xamples/unreserved-entry-pass/on_search/Return_a_catalog_for_unreserved_entry_pass_2.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,6 +265,15 @@ message:
count: 6
minimum:
count: 1
margin:
maximum:
measure:
value: '10'
unit: PERCENT
minimum:
measure:
value: '8'
unit: PERCENT
time:
label: VALIDITY
duration: P2D
Expand Down Expand Up @@ -353,6 +362,15 @@ message:
count: 4
minimum:
count: 1
margin:
maximum:
measure:
value: '10'
unit: PERCENT
minimum:
measure:
value: '8'
unit: PERCENT
time:
label: VALIDITY
duration: P2D
Expand Down
19 changes: 18 additions & 1 deletion api/components/examples/unreserved-entry-pass/on_search/on_search_request_3.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,15 @@ message:
# range:
# min: 1
# max: 10

margin:
maximum:
measure:
value: '10'
unit: PERCENT
minimum:
measure:
value: '8'
unit: PERCENT
time:
label: VALIDITY
duration: P2D
Expand Down Expand Up @@ -359,6 +367,15 @@ message:
count: 4
minimum:
count: 1
margin:
maximum:
measure:
value: '10'
unit: PERCENT
minimum:
measure:
value: '8'
unit: PERCENT
time:
label: VALIDITY
duration: P2D
Expand Down
10 changes: 10 additions & 0 deletions ...les/unreserved-entry-pass/on_select/Return_a_selected_item_for_unreserved-entry-pass.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,11 @@ message:
quantity:
selected:
count: 1
margin:
selected:
measure:
value: '10'
unit: PERCENT
time:
label: VALIDITY
duration: P2D
Expand Down Expand Up @@ -178,6 +183,11 @@ message:
quantity:
selected:
count: 1
margin:
selected:
measure:
value: '10'
unit: PERCENT
time:
label: VALIDITY
duration: P2D
Expand Down
10 changes: 10 additions & 0 deletions ...mponents/examples/unreserved-entry-pass/on_select/on_select_request_order_level_form.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,11 @@ message:
quantity:
selected:
count: 1
margin:
selected:
measure:
value: '10'
unit: PERCENT
time:
label: VALIDITY
duration: P2D
Expand Down Expand Up @@ -159,6 +164,11 @@ message:
quantity:
selected:
count: 1
margin:
selected:
measure:
value: '10'
unit: PERCENT
time:
label: VALIDITY
duration: P2D
Expand Down
10 changes: 10 additions & 0 deletions api/components/examples/unreserved-entry-pass/on_select/on_select_request_submission.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,11 @@ message:
quantity:
selected:
count: 1
margin:
selected:
measure:
value: '10'
unit: PERCENT
time:
label: VALIDITY
duration: P2D
Expand Down Expand Up @@ -166,6 +171,11 @@ message:
quantity:
selected:
count: 1
margin:
selected:
measure:
value: '10'
unit: PERCENT
time:
label: VALIDITY
duration: P2D
Expand Down
10 changes: 10 additions & 0 deletions ...ents/examples/unreserved-entry-pass/on_select/on_select_rquest_submission_order_form.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,11 @@ message:
quantity:
selected:
count: 1
margin:
selected:
measure:
value: '10'
unit: PERCENT
time:
label: VALIDITY
duration: P2D
Expand Down Expand Up @@ -161,6 +166,11 @@ message:
quantity:
selected:
count: 1
margin:
selected:
measure:
value: '10'
unit: PERCENT
time:
label: VALIDITY
duration: P2D
Expand Down
Loading