317 bigquery using dbi#336
Open
javier-gracia-tabuenca-tuni wants to merge 13 commits into
Open
Conversation
…olumn of `data.table::IDate`. Fixses OHDSI#326
…s delayIfNecessaryForDdl and delayIfNecessaryForInsert, just like it does for JDBC
… tests/testthat/setup.R
now uses DBI need atleast bq project on server= additional parameters go on extraSettings extraSettings$billing sets the billing project if this differes from main project extraSettings can take any other parameter that is pass to bigrquery::bq_auth, default is none. this allows for any possible use of bigrquery::bq_auth
if getTableNames is of format "<project>.<dataset>" return table names on it if getTableNames is of format "<dataset>" uses the project given on creation as server=
getSchemaNames.DatabaseConnectorDbiConnection so that list of tables appear in Rstudion connections
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before you do a pull request, you should always file an issue and make sure the package maintainer agrees that it’s a problem, and is happy with your basic proposal for fixing it. We don’t want you to spend a bunch of time on something that we don’t think is a good idea.
Additional requirements for pull requests:
Adhere to the Developer Guidelines as well as the OHDSI Code Style.
If possible, add unit tests for new functionality you add.
Restrict your pull request to solving the issue at hand. Do not try to 'improve' parts of the code that are not related to the issue. If you feel other parts of the code need better organization, create a separate issue for that.
Make sure you pass R check without errors and warnings before submitting.
Always target the
developbranch, and make sure you are up-to-date with the develop branch.