[18.0][ADD] spreadsheet_quotation by cifuentesmx · Pull Request #111 · OCA/spreadsheet

cifuentesmx · 2026-04-08T07:17:58Z

This commit adds a new module that allows users to create and manage spreadsheet calculators linked to sale order templates in Odoo. Key features include:

Creation of a spreadsheet calculator from a sale order template.
Automatic assignment of a copy of the spreadsheet to sale orders created from the template.
Integration of field sync functionality to map spreadsheet columns to sale order line fields.
User-friendly interface for managing mappings and syncing values back to sale orders.

Documentation and tests have been included to ensure functionality.

This is related to the #74 issue

This commit adds a new module that allows users to create and manage spreadsheet calculators linked to sale order templates in Odoo. Key features include: - Creation of a spreadsheet calculator from a sale order template. - Automatic assignment of a copy of the spreadsheet to sale orders created from the template. - Integration of field sync functionality to map spreadsheet columns to sale order line fields. - User-friendly interface for managing mappings and syncing values back to sale orders. Documentation and tests have been included to ensure functionality.

This commit improves the readability of the code by applying consistent formatting and simplifying conditional statements across multiple files. Key changes include: - Updated the summary in the manifest file for better readability. - Simplified conditional checks in the `sale_order.py` model. - Enhanced formatting in JavaScript and XML files for better clarity. - Improved comments for better understanding in the `spreadsheet_quotation_create.py` wizard. These changes aim to maintain a clean codebase and enhance maintainability.

legalsylvain

Thanks a lot ! looks promising !

Tested on runboat. Step to reproduce :

link the demo "Offiche Furnitures" quotation template to the demo "Demo spreadsheet".
-click on open calculator.

there is the following error :

I think it can be hard to understand how to configure.
could you

add a simple demo data ?
based on demo data, add a screenshot in a new file, named configure.md ?

thanks !

cifuentesmx · 2026-04-09T01:07:25Z

Sure, I'll be adding this step-by-step installation guide to the repo.

@legalsylvain these screenshots come from this runboat, you can see this actually working

1. Add quotation templates in `settings`

2. Create a new template & create a calculator

3. Map Sync fields > columns to fields

4. Save template > create a quotation from template and open calculator

5. add new lines to the calculator, save and sync

6. Add new products if any

7. Quotation updated!!!

…tion This commit introduces seven new images to the documentation and updates the usage guide to include a step-by-step process for using the spreadsheet quotation calculator. The INSTALL.md file has been removed as it was no longer needed.

…ct directory.

legalsylvain · 2026-04-09T08:10:11Z

woh ! looks detailled ! I'll take a look. Thanks !

legalsylvain · 2026-04-28T09:40:50Z

Hi. Thanks a lot for your contribution and the explanation.

tested on runboat :

works great.
a nice to have, I confirmed a sale order, then try to change quantity invoiced & quantity received. As there are computed fields, it should fail. In fact It fail, but :
-> the error is not explicit.
-> I don't see possibility to "redo" the spreadsheet".

cifuentesmx · 2026-04-28T18:21:41Z

* a nice to have, I confirmed a sale order, then try to change quantity invoiced & quantity received. As there are computed fields, it should fail. In fact It fail, but :

* -> the error is not explicit.

* -> I don't see possibility to "redo" the spreadsheet".

Thanks for the feedback, I'll get to this as soon as I get some extra time.

What do you mean by 'redo the spreadsheet'? I'm not sure whats the suggestion here.

If I get it right, it should prevent the calculator to open if the order is confirmed or cancelled, is that it?

legalsylvain · 2026-05-26T10:03:48Z

If I get it right, it should prevent the calculator to open if the order is confirmed or cancelled, is that it?

I don't know !

prevent to open
or prevent to update the file

what you think easier.

- Implemented checks in the SaleOrder model to prevent synchronization of cancelled or confirmed sales orders. - Added a new method `action_sync_spreadsheet_order_lines` to handle the synchronization process. - Updated the JavaScript component to utilize the new synchronization method and handle error messages more effectively. - Added unit tests to verify synchronization behavior for different order states.

cifuentesmx · 2026-06-19T11:35:08Z

I don't know !
* prevent to open

* or prevent to update the file
what you think easier.

I've improved error messages to make it more explicit, and prevent the update. @legalsylvain

legalsylvain · 2026-06-19T12:55:42Z

sorry. I have very few time to review for the time being. but i can merge this PR, if it has other approval.

max3903 · 2026-06-19T15:57:36Z

/ocabot merge nobump

OCA-git-bot · 2026-06-19T15:57:44Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-111-by-max3903-bump-nobump, awaiting test results.

OCA-git-bot · 2026-06-19T16:03:02Z

@max3903 The merge process could not be finalized, because command twine upload --disable-progress-bar --non-interactive --repository-url https://upload.pypi.org/legacy/ -u __token__ odoo_addon_spreadsheet_quotation-18.0.1.0.0.5-py3-none-any.whl failed with output:

Uploading distributions to https://upload.pypi.org/legacy/
Uploading odoo_addon_spreadsheet_quotation-18.0.1.0.0.5-py3-none-any.whl
�[33mWARNING �[0m Error during upload. Retry with the --verbose option for more details. 
�[31mERROR   �[0m HTTPError: 429 Too Many Requests from https://upload.pypi.org/legacy/  
         Too Many Requests

max3903 · 2026-06-20T07:03:26Z

/ocabot merge nobump

OCA-git-bot · 2026-06-20T07:03:34Z

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-111-by-max3903-bump-nobump, awaiting test results.

OCA-git-bot · 2026-06-20T07:08:33Z

@max3903 The merge process could not be finalized, because command twine upload --disable-progress-bar --non-interactive --repository-url https://upload.pypi.org/legacy/ -u __token__ odoo_addon_spreadsheet_quotation-18.0.1.0.0.5-py3-none-any.whl failed with output:

Uploading distributions to https://upload.pypi.org/legacy/
Uploading odoo_addon_spreadsheet_quotation-18.0.1.0.0.5-py3-none-any.whl
�[33mWARNING �[0m Error during upload. Retry with the --verbose option for more details. 
�[31mERROR   �[0m HTTPError: 429 Too Many Requests from https://upload.pypi.org/legacy/  
         Too Many Requests

Roberto added 2 commits April 8, 2026 00:57

cifuentesmx marked this pull request as ready for review April 8, 2026 07:21

cifuentesmx changed the title ~~[ADD] Introduce Spreadsheet Quotation Calculator~~ [18.0][ADD] Introduce Spreadsheet Quotation Calculator Apr 8, 2026

legalsylvain requested changes Apr 8, 2026

View reviewed changes

Comment thread spreadsheet_quotation/readme/INSTALL.md Outdated

cifuentesmx requested a review from legalsylvain April 9, 2026 01:13

cifuentesmx marked this pull request as draft April 9, 2026 01:15

cifuentesmx marked this pull request as ready for review April 9, 2026 01:38

Fix link for spreadsheet_quotation in README.md to point to the corre…

49f9aa9

…ct directory.

Merge branch 'OCA:18.0' into 18.0

b660d0e

OCA-git-bot added series:18.0 mod:spreadsheet_quotation Module spreadsheet_quotation labels May 26, 2026

Roberto and others added 2 commits June 19, 2026 05:19

Merge branch '18.0' into 18.0

dafe10c

max3903 added this to the 18.0 milestone Jun 19, 2026

max3903 added enhancement New feature or request needs review labels Jun 19, 2026

max3903 changed the title ~~[18.0][ADD] Introduce Spreadsheet Quotation Calculator~~ [18.0][ADD] spreadsheet_quotation Jun 19, 2026

max3903 approved these changes Jun 19, 2026

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label Jun 19, 2026

OCA-git-bot removed the bot is merging ⏳ label Jun 19, 2026

OCA-git-bot added the bot is merging ⏳ label Jun 20, 2026

OCA-git-bot removed the bot is merging ⏳ label Jun 20, 2026

Uh oh!

Conversation

cifuentesmx commented Apr 8, 2026

Uh oh!

legalsylvain left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cifuentesmx commented Apr 9, 2026

Sure, I'll be adding this step-by-step installation guide to the repo.

1. Add quotation templates in settings

2. Create a new template & create a calculator

3. Map Sync fields > columns to fields

4. Save template > create a quotation from template and open calculator

5. add new lines to the calculator, save and sync

6. Add new products if any

7. Quotation updated!!!

Uh oh!

legalsylvain commented Apr 9, 2026

Uh oh!

legalsylvain commented Apr 28, 2026

Uh oh!

cifuentesmx commented Apr 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

legalsylvain commented May 26, 2026

Uh oh!

cifuentesmx commented Jun 19, 2026

Uh oh!

legalsylvain commented Jun 19, 2026

Uh oh!

max3903 commented Jun 19, 2026

Uh oh!

OCA-git-bot commented Jun 19, 2026

Uh oh!

OCA-git-bot commented Jun 19, 2026

Uh oh!

max3903 commented Jun 20, 2026

Uh oh!

OCA-git-bot commented Jun 20, 2026

Uh oh!

OCA-git-bot commented Jun 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

1. Add quotation templates in `settings`

cifuentesmx commented Apr 28, 2026 •

edited

Loading