[19.0][MIG] agreement_legal: Migration to 19.0

[SyncMasta]

Summary

Migrates agreement_legal from 18.0 to 19.0. Two commits:

1. init migration — copies the 18.0 source verbatim with the manifest bumped to 19.0.1.0.0 and an empty migrations/19.0.1.0.0/pre-migration.py placeholder.
2. 19.0 API + dynamic-content mixin — applies all 19.0 breaking-change adaptations and bundles the dynamic-content mixin refactor (extends the work proposed in [18.0][REF] agreement_legal: Replace repeated dynamic field code with mixin #105 for 18.0).

Net change: -477 LOC, no functional regressions on the demo dataset.

19.0 API adaptations

• mail.template._render_template → mail.render.mixin._render_template with engine='inline_template' (5 call sites — all centralised through the new mixin)
• _read_group_stage_ids(self, stages, domain) — drops the third order argument removed in 19.0
• action_view_agreement — drops view_type='form' (no-op in 19.0)
• copy() — adds ensure_one() for explicit single-record semantics under the new 19.0 multi-record copy API
• _compute_to_review_date — extends @api.depends to include agreement_type_id.review_days (was missing, causing stale values when the agreement type was changed)

Dynamic-content mixin

Builds on the design proposed in #105 (1 approval, awaiting merge on 18.0). The 19.0 version of the mixin is a strict superset of #105: it ships the same field-editor block (field_id, sub_object_id, sub_model_object_field_id, default_value, copyvalue, onchange_copyvalue) plus a new _render_dynamic() helper that replaces the 5 duplicated _compute_dynamic_* blocks. Concrete models (agreement, agreement.section, agreement.clause, agreement.recital, agreement.appendix) inherit the mixin and override _get_render_partner() to declare which partner's lang to render with.

The @api.depends triggers on the dynamic-content compute methods are now correct (they were missing in 18.0, leading to stale rendered values when the source field changed).

Views / JS

• Kanban view rewritten from Bootstrap-4 markup (data-toggle, o_dropdown_kanban, fa-ellipsis-v, oe_kanban_color_*) to the native 19.0 kanban-card slots (<header>/<main>/<footer>, kanban_color_picker widget, many2one_avatar_user, highlight_color attribute).
• Drops the OWL FormView/ListView/KanbanView t-inherit hack (static/src/{js,xml}/*) which patched a Create-From-Template button onto the form-create button via xpath on the o_form_button_create CSS selector — fragile and broken in 19.0. Replaced with a list-view <header> action button calling the existing wizard action.
• All js_class attributes and the asset manifest block dropped accordingly.

Report

Bootstrap 5: table-condensed (BS3 legacy) → table-sm.

Tests

test_read_group_stage_ids adapted to the 2-argument signature.

Test plan

• pre-commit run -a clean
• ruff format --check clean
• OCA CI: test with Odoo, test with OCB, codecov
• Reviewers: please verify the PDF rendering matches the 18.0 baseline (the inline-template engine that mail.render.mixin uses is the same one mail.template._render_template was forwarding to, so byte-identity is expected, but worth confirming on the demo dataset)

Related

• Replaces / supersedes the dynamic-field-editor refactor for the 19.0 branch from [18.0][REF] agreement_legal: Replace repeated dynamic field code with mixin #105 (kept compatible — if [18.0][REF] agreement_legal: Replace repeated dynamic field code with mixin #105 lands first on 18.0, no rebase needed)
• Module-tree status: agreement_legal was the largest gap on 19.0 after agreement ([19.0][MIG] agreement: Migration to 19.0 #99 ✅) and agreement_rebate ([19.0][MIG] agreement_rebate: Migration to 19.0 #108 ✅, [19.0][MIG] agreement_rebate_partner_company_group: Migration to 19.0 #110 ✅). agreement_sale ([19.0][MIG] agreement_sale: Migration to 19.0 #100) is open.

🤖 Generated with Claude Code

[CRogos]

Migration guide not followed...
We should also apply the changes suggested in the roadmap. I think this PR should be closed.