fix(templates): source-verify app templates and consolidate audit fixes#100
fix(templates): source-verify app templates and consolidate audit fixes#100bakerboy448 wants to merge 1 commit into
Conversation
ed4f844 to
82f57ea
Compare
|
Ran every endpoint change in this PR against real Traffic-confirmed (beyond source-code verification already in the PR body):
Confirmed safe to remove — zero traffic across the full retention window (~7 days), any status code:
One weaker justification, not a red flag but worth a maintainer's eye: Seerr's Everything else (additions across Maintainerr, Bazarr, DAPS, Prowlarr Worth flagging separately: this PR fully deletes |
|
Ran this diff against ~7 days of VERIFIED (live traffic on this instance)
No other addition in this diff (bazarr, daps, maintainerr, seerr, remaining prowlarr changes) corresponds to an observed rejection on this instance — that's not evidence they're wrong, just that this deployment's traffic doesn't exercise them (e.g. maintainerr here only ever calls Not a registered consumer here at all (no traffic either way): nabarr, omegabrr, recyclarr, cross-seed, titlecardmaker, unmanic. Grounded in code review, not traffic-tested (worth a second look before merging)
[HttpGet("/api/v1/indexer/{id:int}/newznab")]
[HttpGet("{id:int}/api")]
public async Task<IActionResult> GetNewznabResponse(...)but One unrelated observation while cross-referencing: the deployed Happy to share the raw log greps if useful. |
|
2 weeks ago or so you and your AI added cross-seed, now you and your AI are removing it lol.. I am a bit confused here. also, squash all this please (14 commits) |
|
Torznab doesn't seem to be an available prowlarr starr proxy endpoint so not sure the benefit of leaving crossseed in - hence the removal |
Consolidated template audit for 12 third-party apps. Each template was checked against upstream source code so StarrProxy only grants endpoints the app actually calls. Replaces and supersedes Notifiarr#98 and Notifiarr#99. - Kometa (radarr+sonarr): add bulk import/editor, tag POST, languageprofile, seasonpass; sonarr add /series/import, /seasonpass, remove ineffective POST /series; radarr add GET /movie/{id} (live traffic confirmed Kometa fetches single-movie detail by ID, causing recurring 401s when only the bulk list was granted) - Prowlarr (radarr+sonarr): add DELETE /indexer/{id}; remove unused testall, config/indexer*, indexerflag, system/status - Maintainerr (radarr+sonarr): expand to full servarr helper surface (command, editor, history, qualityprofile, files, exclusions/bulk, tags) - Seerr: replaces Jellyseerr + Overseerr templates (unified successor with automatic migration from either project); verified against seerr-team/seerr; add delete, episode/monitor, tag PUT - Bazarr: add history endpoint; sonarr add languageprofile - DAPS: expand to actual arrpy.py call surface (movie/series files, history, queue/bulk, delete paths) - Unmanic: expand grants (queue, series, tag, qualityprofile, episodefile); add series/{id} GET for webhook rules - Nabarr: trim to actual GET/POST calls only - Omegabrr: add tag GET for tag-filter configs - Recyclarr: remove unused command/{id} - Cross-seed: remove prowlarr/cross-seed.json (only uses radarr/sonarr /parse) - Titlecardmaker: remove unused rootfolder, series/lookup - README: move Jellyseerr/Overseerr to removed list, Seerr is active - CI: re-enable Renovate (.github/renovate.json) — `enabled: false` was added by a195176 with fork-scoped intent but landed on develop directly, disabling Renovate project-wide; restored to pre-a195176 state Closes Notifiarr#98, closes Notifiarr#99. Co-Authored-By: Claude <[email protected]>
2645304 to
cac74f7
Compare
Summary
Consolidated template audit for 12 third-party apps, one commit per app/template. Replaces and supersedes #98 and #99.
Each template was checked against upstream source code so StarrProxy only grants endpoints the app actually calls.
Template changes
Kometa (radarr + sonarr)
import/editor, tag POST, languageprofile, seasonpass/series/import,/seasonpass; remove ineffectivePOST /seriesGET /movie/{id}— confirmed via live traffic that Kometa's scheduled run fetches single-movie detail by ID; only the bulk/movielist was granted, causing recurring 401sProwlarr (radarr + sonarr)
DELETE /indexer/{id}(indexer removal during sync)Maintainerr (radarr + sonarr)
Seerr (replaces Jellyseerr + Overseerr)
jellyseerr.jsonandoverseerr.json— Seerr is the unified successor (automatic migration from either project)seerr.json: delete, episode/monitor, tag PUTOther apps
arrpy.py)series/{id}GET for webhook rulescommand/{id}prowlarr/cross-seed.json(only uses radarr/sonarr/parse)Docs
CI
.github/renovate.json):enabled: falsewas added bya195176with fork-scoped intent ("chore: disable renovate on fork") but landed on this repo'sdevelopdirectly, disabling Renovate project-wide. Restored to the pre-a195176state.Supersedes