Descoping CR Feature#4206
Open
wavehassman wants to merge 40 commits into
Open
Conversation
…ma-changes #4168 schema changes
…oval-logic #4170 Update Approval Logic
…slack-notif-diff-on-cr-submit
#4173 simplified making a CR
…k-notif-diff-on-cr-submit #4171 Slack Notification with Diff
…e-gate-input #4176 added dateCompleted to stage gate
…n making a new project
…ve-old-cr-stuff #4174 frontend changes
…lack-button #4172 started cr approve slack button
chpy04
requested changes
May 14, 2026
Contributor
There was a problem hiding this comment.
Functionality notes:
- When I change the lead and then change another part of a project (such as the name or description or budget), it gives this error:
(this does not appear to be an issue on work packages) - Changing only the budget on a project makes a standard change request not a budget change request (I believe this was already a bug). This also feeds into functionality that I don't think we don't have right now: we should make multiple change requests if different kinds are required. For example, if I change the leadership, budget, and description, there should be a leadership CR, a standard CR, and a budget CR. On a completely seperate not I don't think we shoul dactually need CRs for changing project information other than budget, but thats another thing. If we want to say this bullet is out of scope for this branch thats fine but should definately go in the fall CR epic
- When I have the modal to submit a CR and click the dropdown to select a reviewer it is cut off by the modal and I have to scroll

- After I submit a CR it takes me back to the CR page. it should take me to the change requests page
- implement and create change request buttons are not merged into one but they should be
- Allow any head or admin plus requested reviewer to review on slack
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Removes all legacy CR UI elements and updates the CR detail page as part of the broader CR descoping epic. Specifically:
Checklist
It can be helpful to check the
ChecksandFiles changedtabs.Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
yarn.lockchanges (unless dependencies have changed)Closes #4157