Add an "overlay" for variables specific to NorESM and CESM#33
Merged
Conversation
mvertens
marked this pull request as draft
July 21, 2026 19:15
mvertens
marked this pull request as ready for review
July 22, 2026 10:02
Author
|
@adagj - this PR should address the issue you raised regarding how to keep CESM and NorESM aerosol and surface emissions separate and support both. I'm happy to try to merge in your changes if you want as a possible next step - if you point me to your branch. |
TomasTorsvik
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Add an "overlay" for variable defaults so each model keeps only its own differences
Previously, NorESM's aerosol/chemistry plotting defaults were written directly into the shared lib/adf_variable_defaults.yaml. That made the shared file drift from upstream and hard to maintain. This PR adds a small feature so a run can lay a second, short defaults file on top of the shared one — overriding only the variables that differ, and leaving everything else untouched.
In particular, the NorESM overlay file - adf_variable_defaults_noresm - will contain NorESM aerosol and surface emission variables whereas the CESM overlay file adf_variable_defaults_cesm will contain CESM aerosol variables.
IMPORTANT:
The NorESM/CESM aerosol variable defaults were moved out of the shared adf_variable_defaults.yaml into per-model overlay files. As a result, defaults_overlay_file is required for any run whose variable list includes those aerosol variables:
Without it, the derived aerosols won't be generated (their derivable_from/derivation_formula and aerosol_zonal_list now live in the overlay), and the remaining aerosol vars lose their plotting defaults.
Changes:
Testing:
A full NorESM ne16 run loads the shared file + NorESM overlay, with the aerosol variables getting their overlay settings and producing tables/plots as before.