feat: add --dump-manifests flag to argo-workflows create#3099
Open
npow wants to merge 3 commits into
Open
Conversation
Contributor
Greptile SummaryThis PR adds a manifest-dump mode to Argo Workflows creation. The main changes are:
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (5): Last reviewed commit: "test: add --dump-manifests integration t..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
npow
force-pushed
the
npow/argo-dump-manifests-clean
branch
from
fc37072 to
09416f4
Compare
Collaborator
Author
|
@saikonen can you review? |
npow
force-pushed
the
npow/argo-dump-manifests-clean
branch
from
09416f4 to
c1cc018
Compare
npow
force-pushed
the
npow/fix-argo-only-json-export
branch
from
8a1f532 to
c416489
Compare
npow
force-pushed
the
npow/argo-dump-manifests-clean
branch
from
c1cc018 to
598bed0
Compare
Output all Kubernetes manifests as JSON without connecting to the cluster or uploading a code package. Reuses export_all_json() to produce a dict with workflow_template, cron_workflow, and sensor keys. Suitable for GitOps workflows with kubectl apply, kustomize, or ArgoCD.
- Register @click.option("--dump-manifests") on the create command
- Add dump_manifests param to create() and skip deployer attributes / cluster access
- Pass dump_manifests=dump_manifests to make_flow()
- Output manifests via export_all_json() when --dump-manifests is set
Co-Authored-By: Claude Sonnet 4.6 (1M context) <[email protected]>
Adds _compile_flow_to_dump_manifests() helper and TestArgoCliDumpManifests covering: valid JSON output, workflow_template presence, no cron/sensor for plain flows, placeholder package values in manifest, and scheduled flow cron_workflow export. Co-Authored-By: Claude Sonnet 4.6 (1M context) <[email protected]>
npow
force-pushed
the
npow/argo-dump-manifests-clean
branch
from
24ec874 to
da16b9a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Depends on #3095.
Changes (post-review)
Test plan
🤖 Generated with Claude Code