Skip to content

Add values.schema.json#221

Merged
theboringstuff merged 6 commits into
mainfrom
feature/add-values-schema
Jun 16, 2026
Merged

Add values.schema.json#221
theboringstuff merged 6 commits into
mainfrom
feature/add-values-schema

Conversation

@theboringstuff

@theboringstuff theboringstuff commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

Problem

It is required to introduce values.schema.json for the chart

Solution

  • Added values.schema.json
    • Did not add description for the fields, since it would introduce duplication
    • Allowed additional properties to keep backward compatibility
    • Schema is detailed for SM-owned parameters, for others it is generic objects/arrays/etc
  • Added missing labels required by release window

Test Cases

  1. Make sure SiteManager deploys OK with both AppDeployer/ArgoCD
  2. Make sure SiteManager schema validation fails if some incorrect types are specified

Example incorrect values:

createClusterAdminEntities: 123

Expected error:

$ helm template charts/site-manager/ -f env~/values.yaml 
Error: values don't meet the specifications of the schema(s) in the following chart(s):
site-manager:
- at '/createClusterAdminEntities': 'anyOf' failed
  - at '/createClusterAdminEntities': got number, want boolean
  - at '/createClusterAdminEntities': got number, want string

@theboringstuff theboringstuff changed the title add values.schema.json Add values.schema.json Jun 16, 2026
@theboringstuff theboringstuff marked this pull request as ready for review June 16, 2026 06:38
@theboringstuff theboringstuff merged commit 1a2fc17 into main Jun 16, 2026
39 of 43 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants