feat: implement dynamic game feel with animated backgrounds, combo-re… - #2
Open
Nerdlin wants to merge 2 commits into
Open
Conversation
…active visuals, and full-screen application architecture
Owner
Author
|
@copilot resolve the merge conflicts in this pull request |
1 similar comment
Owner
Author
|
@copilot resolve the merge conflicts in this pull request |
There was a problem hiding this comment.
Pull request overview
Adds dynamic "game feel" polish: an animated background that reacts to the current combo via a new global atom, line-clear spark particles per board cell, and additional SFX hooks (startup preload, multiplayer placement/combo/invalid/game-over sounds).
Changes:
- New
activeComboAtomsynced from each game's combo shared value viauseAnimatedReaction+runOnJS, consumed byAnimatedBackgroundto vary speed, opacity, and pulse. - Per-cell
Sparkparticles (8 perGridBlock) emitted on line clear inBlockGrid. - Sound preloading at app startup and multiplayer SFX wiring (placement, combo, invalid drop, game over).
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| hooks/useAppState.tsx | Adds exported activeComboAtom for global combo state. |
| app/index.tsx | Preloads sound assets at startup. |
| components/AnimatedBackground.tsx | Reacts to combo: faster cycle, stronger overlay, pulse on increase. |
| components/game/Game.tsx | Syncs combo to atom, resets on unmount; spring config field accidentally renamed mass → max. |
| components/game/MultiplayerGame.tsx | Syncs combo to atom; adds placement/combo/invalid/game-over SFX. |
| components/game/BlockGrid.tsx | Adds Spark component and per-block spark burst on line clear. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+150
to
+152
| // Trigger neon sparks animation | ||
| sparkProgress.value = 0; | ||
| sparkProgress.value = withTiming(1, { duration: 550 }); |
Comment on lines
+83
to
+87
| useAnimatedReaction(() => { | ||
| return combo.value; | ||
| }, (curCombo) => { | ||
| runOnJS(setActiveCombo)(curCombo); | ||
| }); |
Co-authored-by: Copilot Autofix powered by AI <[email protected]>
Owner
Author
|
@copilot resolve the merge conflicts in this pull request |
Copilot stopped work on behalf of
Nerdlin due to an error
May 31, 2026 13:34
Copilot stopped work on behalf of
Nerdlin due to an error
May 31, 2026 13:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…active visuals, and full-screen application architecture