feat: fetcher reads retry_after from body when Cloudflare returns retry-after:0#148
Open
kribor wants to merge 1 commit into
Open
feat: fetcher reads retry_after from body when Cloudflare returns retry-after:0#148kribor wants to merge 1 commit into
kribor wants to merge 1 commit into
Conversation
…ry-after:0 Cloudflare 429 responses set retry-after:0 in the header but encode the actual delay (e.g. 30 s) in the JSON body as retry_after. The header value parses to 0, which previously fell through to exponential backoff and caused premature retries. Now we check res.body.retry_after for any 429/503 where the header-based timeout is ≤ 0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
retry-after: 0in the HTTP header but encode the actual delay (e.g. 30 s) in the JSON body asretry_after0fell through to exponential backoff, causing premature retriesgetRetryTimeoutchecksres.body.retry_afterfor any 429/503 where the header-based timeout resolves to ≤ 0Test plan
retryAfter cloudflare bodycovers the Cloudflare pattern:retry-after: 0header +{ retry_after: 2 }in bodyretryAfterandretryAfter datetests continue to pass