Support build cubin & Add unittest#16
Open
SpenserCai wants to merge 8 commits into
Open
Conversation
Author
|
@Narsil @ivarflakstad This PR is designed to enable precompilation of Cubin for loading on Candle. The support for CUDARC has been completed (chelsea0x3b/cudarc#505). If possible, could you please help review the PR. Thank you very much |
haricot
reviewed
Dec 19, 2025
Author
|
@haricot @ivarflakstad Fixed |
haricot
approved these changes
Dec 22, 2025
Contributor
There was a problem hiding this comment.
Approved: tested locally with:
NVCC_CCBIN="gcc-14" cargo test --test build_cubin_test -- --nocapture --> OK
Thank you!
Reflection on another PR topic: We could add support for a CUDA_ROOT_LEGACY or NVCC_BIN variable to be able to point to a legacy CUDA root or a specific nvcc binary (useful when the driver is newer than nvcc. ex: driver cuda_13.0 vs nvcc 12.9).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support build cubin & Add unittest
This pull PR provides support for compiling cubin with bindgen_cuda. In some cases, it is necessary to directly compile cubin through bindgen_cuda, so support has been added, ensuring backward compatibility, and unit tests as well as the compilation of cubin on candle-kernel have all passed.
Test Result
Unit test
Test in candle-kernel build cubin