feat: implement secure defaults audit as release checklist gate (#797) - #887
Merged
Nanle-code merged 2 commits intoAug 31, 2026
Merged
Conversation
…e-code#797) Add automated tests and documentation verifying that StarForge ships with privacy-respecting, secure defaults before each release. - Add `SECURE_DEFAULTS_AUDIT.md` with full checklist (automated + manual) - Add `tests/secure_defaults_audit.rs` with 20+ automated checks covering: - Telemetry opt-out and local-only guarantees - AI telemetry cloud disabled by default - Friendbot restricted to testnet only - Default network is testnet - Plugin trust sources restricted to known repos - Wallet encryption is opt-in - File permissions restricted (0600) - Network passphrases validated - Add `secure-defaults` CI job to `.github/workflows/ci.yml` - Add `secure-defaults` gate to `.github/workflows/release.yml` (blocks release tagging) - Update `CI_ENFORCEMENT.md` with job documentation and merge requirements - Update `CONTRIBUTING.md` and `CONTRIBUTOR_QUICK_REFERENCE.md` with audit commands 🤖 Generated with Codebuff Co-Authored-By: Codebuff <[email protected]>
|
@JemimahEkong Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Collaborator
|
@JemimahEkong Please resolve conflict!!! |
1 similar comment
Collaborator
|
@JemimahEkong Please resolve conflict!!! |
Contributor
Author
|
@Manuelshub conflicts resolved. kindly review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #797
Summary
Adds a formal secure-defaults audit that runs in CI on every push/PR and gates release tagging, backed by automated checks plus a maintainer attestation checklist for the items that can't be verified by code alone.
What was implemented
SECURE_DEFAULTS_AUDIT.md— 15 automated checks (A1–A15) verified by CI, plus 8 manual attestation items (M1–M8) requiring maintainer sign-off, with an attestation template and release process integration instructions.tests/secure_defaults_audit.rs— 20+ automated tests covering:CI Integration:
secure-defaultsjob in.github/workflows/ci.yml— runs on every push/PRsecure-defaultsgate in.github/workflows/release.yml— blocks release tagging until audit passesDocumentation Updates:
CI_ENFORCEMENT.md— job description, regression table, merge requirementsCONTRIBUTING.md— audit command in code quality checksCONTRIBUTOR_QUICK_REFERENCE.md— quick reference table, CI pipeline list