feat(ci): verify Cargo.lock reproducibility across Linux, macOS, and Windows - #875
Merged
Merged
Conversation
|
@gospeltout Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements cross-platform
Cargo.lockreproducibility verification for StarForge. It ensures that locked builds (--locked) do not mutate dependency resolution, fail unexpectedly, or introduce platform-dependent lockfile drift across Linux, macOS, and Windows.Closes #654
Type of Change
Changes Made
src/utils/cargo_lock.rs): Implementedverify_cargo_lock_reproducibilityto validate lockfile immutability, check manifest/lockfile existence, check toolchain availability, detect out-of-sync dependency errors, generate line-by-line diff summaries, and auto-restore mutated lockfiles.starforge verify lockfile): Addedstarforge verify lockfiletosrc/commands/verify.rswith--path,--json, and--strictoptions.git diff --exit-code Cargo.lockchecks across Linux, macOS, and Windows matrix targets in.github/workflows/ci.yml,.gitlab-ci.yml, andJenkinsfile.DEVELOPER_GUIDE.md,CI_ENFORCEMENT.md, andBUILD_TROUBLESHOOTING.mdwith cross-platform lockfile rules, CLI usage, and resolution troubleshooting instructions.Testing
How has this been tested?
Describe the tests you ran and how to reproduce them.
Command output verification: