Run worker fingerprint capture from mounted script - #256
Draft
alec-flowers wants to merge 1 commit into
Draft
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #256 +/- ##
=======================================
Coverage ? 66.91%
=======================================
Files ? 71
Lines ? 9189
Branches ? 0
=======================================
Hits ? 6149
Misses ? 3040
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
runtime_scripts/fingerprint.py/srtctl-runtimemount with a short, shell-quoted commandsruncommand logging at its existing DEBUG level while removing the stale heredoc explanationWhy
Worker startup previously generated an entire Python program as a string and passed it through bash, srun, container bash, and Python. The nested quoting made the capture path difficult to review and required tests to extract and parse generated source code.
runtime_scripts/is already mounted into every worker container at/srtctl-runtime. Running a normal packaged script makes the execution path direct and keeps the generated worker command small without changing fingerprint filenames or consumers.User impact
There is no configuration or JSON schema change. Workers continue writing
fingerprint_<mode>_w<index>.jsonunder/logs, and fingerprint failures remain non-fatal.Validation
ruff check src/srtctl/ruff format --check src/srtctl/ty checkpytest -q tests --ignore=tests/test_integration_status.py: 828 passed, 2 skipped, 6 deselectedsrtctl/runtime_scripts/fingerprint.pyis packagedLive canary
Job
21231completedCOMPLETED 0:0in 55 seconds on Watchtower GB200 nodewatchtower-blue-cn01, using a checkout synced from this PR commit.The generated connection command included:
The custom benchmark failed unless
/logs/fingerprint_agg_w0.jsonexisted, parsed as JSON, and contained CPU and framework mappings. It completed with:Canary output:
/mnt/lustre01/users/slurm-shared/aflowers/srt-slurm-fingerprint-runtime-script-smoke/outputs/21231