Restore KVzip forward after context errors 🤖🤖🤖#244
Open
fallintoplace wants to merge 1 commit into
Open
Conversation
Signed-off-by: Minh Vu <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
model.model.forwardfrom an innerfinallyaround the KVzip context yield.Root cause
KVzipPress.__call__monkey-patchesmodel.model.forwardbefore yielding to the caller, but the original method was restored only after a normal return from thewithblock. If the caller raised inside the context, the outer cleanup removed hooks and reset internal state without restoringforward, leaving the model patched after exit.Validation
uv run pytest tests/presses/test_kvzip_press.pyuv run isort kvpress/presses/kvzip_press.py tests/presses/test_kvzip_press.pyuv run black kvpress/presses/kvzip_press.py tests/presses/test_kvzip_press.pyuv run flake8 kvpress/presses/kvzip_press.py tests/presses/test_kvzip_press.pyuv run mypy kvpress/presses/kvzip_press.py --check-untyped-defsmake style