Skip to content

Fix: rerotation with multi-gpus #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SimJeg merged 1 commit into from
Jun 16, 2026
+3 −1
Merged

Fix: rerotation with multi-gpus #241

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion kvpress/presses/key_rerotation_press.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,9 +71,11 @@ def _rerotate_cos_sin(x, inv_freq, selected_positions):
``(bsz, num_key_value_heads, n_kept, d)``, matching ``dtype``/``device`` of ``x``.
"""
bsz, num_key_value_heads, n_kept = selected_positions.shape
device = selected_positions.device
device = x.device
device_type = x.device.type
dtype = x.dtype
selected_positions = selected_positions.to(device)
inv_freq = inv_freq.to(device)
# Original positional indices
idx = torch.arange(0, n_kept, device=device) # (n_kept,)
idx = idx.unsqueeze(0) # (1, n_kept)
Expand Down
Loading