[codex] docs: finish infra-controller rename accuracy pass#3097
Draft
kfelternv wants to merge 2 commits into
Draft
[codex] docs: finish infra-controller rename accuracy pass#3097kfelternv wants to merge 2 commits into
kfelternv wants to merge 2 commits into
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
helm-prereqs/setup.shNICO_TAGpath accurately as the NICo Core (nico-core) image and remove the remainingnvmetal-nicoMarkdown referencesWhy
The repository rename work in #2357 fixed part of the documentation, but later setup changes left the operator path inconsistent. The Quick Start stopped at Phase 7h without documenting Flow, the site-agent, the current setup flags, or the actual conditional environment requirements. Historical changelog links also continued to point to the old GitHub Pages reference.
This change synchronizes the operator documentation with the current scripts and maps each old API link to its specific maintained destination.
Related issues
Closes #2358
Type of Change
Breaking Changes
Testing
Verified against upstream
mainat8dc207ab25d8aec3001449ab1b5ea440977f05f0:git diff --check— passbash -n helm-prereqs/setup.sh— passmake -n images-core IMAGE_REGISTRY=registry.example/nico IMAGE_TAG=verify VERSION=verify CI_COMMIT_SHORT_SHA=verify— continues to emit the deliberately renamed local imageregistry.example/nico/nico:verifydeploy/kustomization.yamlmaps the Core placeholder toNICO_REGISTRY_PATH/nico-corewithNICO_TAG, matching the updated README wordingsetup.shand the Quick Startinfra-controller-coreprose, malformed auth URLs, ornvmetal-nicoMarkdown referencesllms.txtindex and return HTTP 200; the corrected auth URL also returns HTTP 200rumdldiagnostics across the four primary issue files decrease from 32 onmainto 27; no new diagnostics occur on edited linesAdditional Notes
make imagesproducesnico, kustomize usesnico-core, and the currently published Helm/setup artifact remainsnvmetal-carbide.ncx-serviceKeycloak client and/org/ncx/API examples were intentionally preserved because they still match the implementation./ok-to-testcopy workflow before checks run.