chore: Update opentelemetry to 0.32.1#3086
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
Summary by CodeRabbit
WalkthroughThis PR bumps OpenTelemetry-related crate versions, updates tracing setup to the newer SDK/exporter API, and changes span attribute recording in logging to use explicit string keys. ChangesOpenTelemetry dependency and API adjustments
Estimated code review effort: 2 (Simple) | ~12 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@crates/api-core/src/logging/api_logs.rs`:
- Around line 192-194: The TODO in api_logs.rs is misleading because grpc_method
only contains the final path segment while grpc_service carries the service
name; update the comment near the deprecated RPC_METHOD handling to reflect that
both fields are needed for attribution. Make sure the wording in the logging
logic around grpc_method and grpc_service does not suggest removing
service-level data, and keep the distinction clear wherever the log fields are
assembled.
- Around line 267-270: The new OpenTelemetry response status code is being
recorded on request_span, but it will be ignored unless the field is declared on
the span first. Update the span declaration in api_logs::request_span to include
RPC_RESPONSE_STATUS_CODE alongside rpc.grpc.status_code, then keep the existing
request_span.record call so the value is actually exported.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: c16357aa-ef30-48ff-944a-268a141f2b53
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (3)
Cargo.tomlcrates/api-core/src/logging/api_logs.rscrates/api-core/src/logging/setup.rs
Opentelemetry has opted to change some of the recommended field names, let's not deal with that right now and instead just keep using the fields we always used.
🔍 Container Scan Summary
Per-CVE detail lives in the per-service |
Should fix https://github.com/NVIDIA/infra-controller/security/dependabot/81
Related issues
https://github.com/NVIDIA/infra-controller/security/dependabot/81
Type of Change
Breaking Changes
Testing
Additional Notes