docs(hy_worldplay/wan22): tighten AI-generated comments and docstrings#314
docs(hy_worldplay/wan22): tighten AI-generated comments and docstrings#314wenqingw-nv wants to merge 1 commit into
Conversation
Per Ruilong's PR #224 request for a separate cleanup pass: trim the agent's chain-of-thought and historical narration from comments and docstrings across the HY-WorldPlay + wan22 integration, leaving tight, user-facing docs plus one-line correctness invariants. Comments and docstrings only -- zero executable-code changes (verified by AST comparison with all string-literal statements stripped). CPU test suite (93 passed) and ruff v0.12.7 format/import checks green. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
Greptile SummaryA documentation-only cleanup pass across 11 files in the HY-WorldPlay and wan22 integrations, trimming AI-generated chain-of-thought narration from comments and docstrings. The PR author verified zero AST changes (parse → strip string literals → compare trees) and the full CPU test suite passes.
Confidence Score: 4/5Safe to merge for runtime behaviour; the one item worth resolving before merging is restoring the upstream attribution in All 11 files are comments/docstrings only and the AST-identity check described in the PR gives strong assurance no executable logic changed. Two comments stand out:
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["_WAN22_TI2V_5B_VAE_KEY_REMAP dict\n(diffusers → flashdreams key map)"] --> B["wan22_ti2v_5b_vae_state_dict_transform()"]
B --> C["Wan22TI2V5BVAEEncoderConfig\ndefault: WAN22_TI2V_5B_VAE_DIFFUSERS_PATH"]
B --> D["Wan22TI2V5BVAEDecoderConfig\ndefault: WAN22_TI2V_5B_VAE_DIFFUSERS_PATH"]
E["WAN22_TI2V_5B_VAE_PATH\nWan2.2_VAE.pth\n(no remap needed)"] -.->|"opt-in alternative\n(comment removed by this PR)"| C
E -.-> D
style E stroke-dasharray: 5 5
style A fill:#ffe0b2
Reviews (1): Last reviewed commit: "docs(hy_worldplay/wan22): tighten AI-gen..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
|
|
||
| Ports the bit pattern of ``hyvideo/prope/camera_rope.py::prope_qkv`` from | ||
| `PRoPE: Projective Positional Encoding for Multiview Transformers | ||
| <https://github.com/Tencent-Hunyuan/HY-WorldPlay/blob/main/hyvideo/prope/camera_rope.py>`_ | ||
| (MIT-licensed) so the native HY-WorldPlay path can apply per-camera | ||
| projective transforms to Q/K/V before attention without importing the | ||
| upstream HY-WorldPlay tree at runtime. | ||
|
|
||
| The transform is a block-diagonal matrix multiply on the per-head feature | ||
| Applies per-camera projective transforms to Q/K/V before attention. The | ||
| transform is a block-diagonal matrix multiply on the per-head feature | ||
| axis: each camera's tokens get multiplied by a 4×4 matrix derived from |
There was a problem hiding this comment.
The old module docstring explicitly stated this file "Ports the bit pattern of hyvideo/prope/camera_rope.py::prope_qkv from PRoPE: Projective Positional Encoding for Multiview Transformers (MIT-licensed)." The cleanup pass removed the upstream GitHub URL and the MIT-license callout entirely. Even though the file header carries Apache-2.0, the ported code originates from a distinct MIT-licensed third-party repository. Dropping the source URL and license notice makes it harder to trace provenance, reconcile against upstream changes, or satisfy any downstream audit that asks where the PRoPE math came from.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
liruilong940607
left a comment
liruilong940607
left a comment
There was a problem hiding this comment.
TY! Always love to see cleanups!
|
/ok to test 6c58789 |
2 participants
Separate doc-cleanup pass requested by @liruilong940607 in the PR #224 review — trim the agent's chain-of-thought / historical narration from comments and docstrings across the HY-WorldPlay + wan22 integration (in the spirit of the omnidreams deslop, #292).